From b4db625d0ccb4fdc6537ed9f6e8ebeaffd1c4873 Mon Sep 17 00:00:00 2001 From: Ravishankar N Date: Sun, 25 Jun 2017 21:50:09 +0530 Subject: glfsheal: prevent background self-heals Problem: For a file in gfid split-brain, the parent directory ('/' during testing) was detected as possibly undergoing heal instead of split-brain in `heal-info` output. Also, it was not being displayed in `info split-brain` output for the same reason. The problem was that when `glfsheal` was run, lookup on '/' triggered a background self-heal due to which processing of '/' during `heal info` failed to acquire locks with errno=EAGAIN. Fix: Set background-self-heal-count to zero while launching glfsheal. Change-Id: I153a7c75af71f213a4eefacf504a0f9806c528a5 BUG: 1318895 Signed-off-by: Ravishankar N Reviewed-on: https://review.gluster.org/13772 CentOS-regression: Gluster Build System NetBSD-regression: NetBSD Build System Smoke: Gluster Build System Reviewed-by: Jeff Darcy --- heal/src/glfs-heal.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'heal/src/glfs-heal.c') diff --git a/heal/src/glfs-heal.c b/heal/src/glfs-heal.c index 07fc6acbf81..fb997948f57 100644 --- a/heal/src/glfs-heal.c +++ b/heal/src/glfs-heal.c @@ -881,6 +881,11 @@ glfsh_set_heal_options (glfs_t *fs, gf_xl_afr_op_t heal_op) { int ret = 0; + ret = glfs_set_xlator_option (fs, "*-replicate-*", + "background-self-heal-count", "0"); + if (ret) + goto out; + if ((heal_op != GF_SHD_OP_SBRAIN_HEAL_FROM_BIGGER_FILE) && (heal_op != GF_SHD_OP_SBRAIN_HEAL_FROM_BRICK) && (heal_op != GF_SHD_OP_SBRAIN_HEAL_FROM_LATEST_MTIME)) @@ -897,6 +902,7 @@ glfsh_set_heal_options (glfs_t *fs, gf_xl_afr_op_t heal_op) ret = glfs_set_xlator_option (fs, "*-replicate-*", "entry-self-heal", "on"); + out: return ret; } -- cgit