From ee05db0b1e8ea27eb63f62b951c71388bcf69c6e Mon Sep 17 00:00:00 2001 From: Raghavendra Talur Date: Fri, 21 Dec 2012 10:50:27 +0530 Subject: extras: Don't update RETVAL with invalid value. Problem: Start and restart functions update the value of RETVAL internally. Assigning $? to RETVAL after function return was updating RETVAL with invalid value. Fix: Removed assignment statement after start and restart functions return. Stop function was always returning 0 as return value due to one extra echo command. Removed echo line. Change-Id: Iec1a83a83463f419dd45e12daf4e5ded80568a3a BUG: 888442 Signed-off-by: Raghavendra Talur Reviewed-on: http://review.gluster.org/4349 Reviewed-by: Anand Avati Tested-by: Anand Avati --- extras/init.d/glusterd-Redhat.in | 4 ---- 1 file changed, 4 deletions(-) (limited to 'extras') diff --git a/extras/init.d/glusterd-Redhat.in b/extras/init.d/glusterd-Redhat.in index 8b17eb18b8e..858f82245d3 100755 --- a/extras/init.d/glusterd-Redhat.in +++ b/extras/init.d/glusterd-Redhat.in @@ -59,8 +59,6 @@ stop() killproc $BASE fi - echo - } @@ -68,7 +66,6 @@ stop() case $1 in start) start - RETVAL=$? ;; stop) stop @@ -81,7 +78,6 @@ case $1 in restart) $0 stop $0 start - RETVAL=$? ;; *) echo $"Usage: $0 {start|stop|status|restart}." -- cgit