From 087703fae449b725ebd82bc3cd65763a016fb098 Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Wed, 11 Oct 2017 13:29:13 +0530 Subject: extras/hooks: Fix errors reported via shellcheck utility Change-Id: I217c6b2a39955f1709bb3452b00d33c2dcb60faa BUG: 1500649 Signed-off-by: Anoop C S --- extras/hook-scripts/stop/pre/S29CTDB-teardown.sh | 4 ++-- extras/hook-scripts/stop/pre/S30samba-stop.sh | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'extras/hook-scripts/stop') diff --git a/extras/hook-scripts/stop/pre/S29CTDB-teardown.sh b/extras/hook-scripts/stop/pre/S29CTDB-teardown.sh index 5fb49bd9e97..e9116c8cfdb 100755 --- a/extras/hook-scripts/stop/pre/S29CTDB-teardown.sh +++ b/extras/hook-scripts/stop/pre/S29CTDB-teardown.sh @@ -12,7 +12,7 @@ VOL= META="all" function parse_args () { - ARGS=$(getopt -l $OPTSPEC -name $PROGNAME $@) + ARGS=$(getopt -l $OPTSPEC -name $PROGNAME "$@") eval set -- "$ARGS" while true; do @@ -51,7 +51,7 @@ function remove_fstab_entry () { fi } -parse_args $@ +parse_args "$@" if [ "$META" = "$VOL" ] then umount "$CTDB_MNT" diff --git a/extras/hook-scripts/stop/pre/S30samba-stop.sh b/extras/hook-scripts/stop/pre/S30samba-stop.sh index 62cf7d1e0d2..6e542da1cc1 100755 --- a/extras/hook-scripts/stop/pre/S30samba-stop.sh +++ b/extras/hook-scripts/stop/pre/S30samba-stop.sh @@ -22,7 +22,7 @@ CONFIGFILE= PIDDIR= function parse_args () { - ARGS=$(getopt -l $OPTSPEC -name $PROGNAME $@) + ARGS=$(getopt -l $OPTSPEC -name $PROGNAME "$@") eval set -- "$ARGS" while true; do @@ -46,8 +46,8 @@ function find_config_info () { echo "Samba is not installed" exit 1 fi - CONFIGFILE=`echo $cmdout | awk {'print $2'}` - PIDDIR=`smbd -b | grep PIDDIR | awk {'print $2'}` + CONFIGFILE=`echo $cmdout | awk '{print $2}'` + PIDDIR=`smbd -b | grep PIDDIR | awk '{print $2}'` } function del_samba_share () { @@ -65,7 +65,7 @@ function sighup_samba () { fi } -parse_args $@ +parse_args "$@" find_config_info del_samba_share $VOL sighup_samba -- cgit