From 72dc1025dc17a650f3838223c78e3205132deba9 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Tue, 10 Feb 2015 19:13:35 +0100 Subject: posix: add ACL translation for the GF_POSIX_ACL_*_KEY xattr Adding support for two virtual extended attributes that are used for converting a binary POSIX ACL to a POSIX.1e long ACL text format. This makes it possible to transfer the ACL over the network to a different OS which can convert the POSIX.1e text format to its native structures. The following xattrs are sent over RPC in SETXATTR/GETXATTR procedures, and contain the POSIX.1e long ACL text format: - glusterfs.posix.acl: maps to ACL_TYPE_ACCESS - glusterfs.posix.default_acl: maps to ACL_TYPE_DEFAULT acl_from_text() (from libacl) converts the text format into an acl_t structure. This structure is then used by acl_set_file() to set the ACL in the filesystem. libacl-devel is needed for linking against libacl, so it has been added to the BuildRequires in the .spec. NetBSD does not support POSIX ACLs. Trying to get/set POSIX ACLs on a storage server running NetBSD, an error will be returned with errno set to ENOTSUP. Faking support, but not enforcing ACLs seems wrong to me. URL: http://www.gluster.org/community/documentation/index.php/Features/Improved_POSIX_ACLs BUG: 1185654 Change-Id: Ic5eb73d69190d3492df2f711d0436775eeea7de3 Signed-off-by: Niels de Vos Reviewed-on: http://review.gluster.org/9627 Tested-by: Gluster Build System Reviewed-by: soumya k Reviewed-by: Raghavendra Bhat --- configure.ac | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) (limited to 'configure.ac') diff --git a/configure.ac b/configure.ac index 2c3b0e31c1c..db51080acf2 100644 --- a/configure.ac +++ b/configure.ac @@ -356,6 +356,39 @@ AC_CHECK_HEADERS([sys/ioctl.h], AC_DEFINE(HAVE_IOCTL_IN_SYS_IOCTL_H, 1, [have sy AC_CHECK_HEADERS([sys/extattr.h]) +dnl NetBSD does not support POSIX ACLs :-( +case $host_os in + *netbsd*) + AC_MSG_WARN([NetBSD does not support POSIX ACLs... disabling them]) + ACL_LIBS='' + USE_POSIX_ACLS='0' + ;; + *) + AC_CHECK_HEADERS([sys/acl.h], , + AC_MSG_ERROR([Support for POSIX ACLs is required])) + USE_POSIX_ACLS='1' + case $host_os in + linux*) + ACL_LIBS='-lacl' + ;; + solaris*) + ACL_LIBS='-lsec' + ;; + *freebsd*) + ACL_LIBS='-lc' + ;; + darwin*) + ACL_LIBS='-lc' + ;; + esac + if test "x${ACL_LIBS}" = "x-lacl"; then + AC_CHECK_HEADERS([acl/libacl.h], , AC_MSG_ERROR([libacl is required for building on ${host_os}])) + fi + ;; +esac +AC_SUBST(ACL_LIBS) +AC_SUBST(USE_POSIX_ACLS) + # libglusterfs/checksum AC_CHECK_HEADERS([openssl/md5.h]) AC_CHECK_LIB([z], [adler32], [ZLIB_LIBS="-lz"], AC_MSG_ERROR([zlib is required to build glusterfs])) @@ -1167,6 +1200,9 @@ AC_SUBST(LIBGFCHANGELOG_LT_VERSION) AC_SUBST(GFAPI_LT_VERSION) AC_SUBST(GFAPI_EXTRA_LDFLAGS) +GFAPI_LIBS="${ACL_LIBS}" +AC_SUBST(GFAPI_LIBS) + dnl this change necessary for run-tests.sh AC_CONFIG_FILES([tests/env.rc],[ln -s ${ac_abs_builddir}/env.rc ${ac_abs_srcdir}/env.rc 2>/dev/null]) @@ -1192,4 +1228,5 @@ echo "XML output : $BUILD_XML_OUTPUT" echo "QEMU Block formats : $BUILD_QEMU_BLOCK" echo "Encryption xlator : $BUILD_CRYPT_XLATOR" echo "Unit Tests : $BUILD_UNITTEST" +echo "POSIX ACLs : $USE_POSIX_ACLS" echo -- cgit