From efd1f08b57a3175cab9bb543833bc3c9192b527d Mon Sep 17 00:00:00 2001 From: Pavan Sondur Date: Mon, 27 Sep 2010 16:20:19 +0000 Subject: replace brick fixes Reviewed ok. Just like commit, maybe we can move 'pause' also to the commit op of replace brick since it can be performed only when replace brick has been started. I'll send in a patch for that soon. ----- Original Message ----- From: "Vijay Bellur" To: glusterfs@dev.gluster.com Sent: Monday, September 27, 2010 7:59:25 PM Subject: [PATCH BUG:1235] replace brick fixes Signed-off-by: Vijay Bellur Signed-off-by: Vijay Bellur BUG: 1235 (Bug for all pump/migrate commits) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235 --- cli/src/cli3_1-cops.c | 30 ------------------------------ 1 file changed, 30 deletions(-) (limited to 'cli') diff --git a/cli/src/cli3_1-cops.c b/cli/src/cli3_1-cops.c index b2a1a78b34e..d92da29138e 100644 --- a/cli/src/cli3_1-cops.c +++ b/cli/src/cli3_1-cops.c @@ -822,7 +822,6 @@ gf_cli3_1_replace_brick_cbk (struct rpc_req *req, struct iovec *iov, char *status_reply = NULL; gf1_cli_replace_op replace_op = 0; char *rb_operation_str = NULL; - char cmd_str[8192] = {0,}; if (-1 == req->rpc_status) { goto out; @@ -894,35 +893,6 @@ gf_cli3_1_replace_brick_cbk (struct rpc_req *req, struct iovec *iov, goto out; } - snprintf (cmd_str, 4096, "gluster volume replace-brick %s %s %s abort >/dev/null", - local->u.replace_brick.volname, src_brick, dst_brick); - - ret = system (cmd_str); - if (ret) { - gf_log ("", GF_LOG_DEBUG, - "add brick failed"); - goto out; - } - - snprintf (cmd_str, 4096, "gluster volume add-brick %s %s >/dev/null", - local->u.replace_brick.volname, dst_brick); - - ret = system (cmd_str); - if (ret) { - gf_log ("", GF_LOG_DEBUG, - "add brick failed"); - goto out; - } - - snprintf (cmd_str, 4096, "gluster --mode=script volume remove-brick %s %s >/dev/null", - local->u.replace_brick.volname, src_brick); - - ret = system (cmd_str); - if (ret) { - gf_log ("", GF_LOG_DEBUG, - "remove brick failed"); - goto out; - } if (rsp.op_ret || ret) rb_operation_str = "replace-brick commit failed"; -- cgit