From 6df8d1d8781f59fbab46c4b016dde0b2d33dd189 Mon Sep 17 00:00:00 2001 From: Nandaja Varma Date: Wed, 4 Feb 2015 13:21:50 +0530 Subject: gluster-cli: Fixing operand error and removing logically dead code. Assign used instead of comparison Coverity CIDs: 1124391 1124346 1124369 1124370 1124702 1124390 1124397 Change-Id: If015382917cad65edc2fee38ae6328f1d072d6f6 BUG: 789278 Signed-off-by: Nandaja Varma Reviewed-on: http://review.gluster.org/9574 Tested-by: Gluster Build System Reviewed-by: Humble Devassy Chirammal Reviewed-by: Kaleb KEITHLEY Reviewed-by: Vijay Bellur --- cli/src/cli-cmd-volume.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'cli') diff --git a/cli/src/cli-cmd-volume.c b/cli/src/cli-cmd-volume.c index 8c9cdf43fe3..5436c76bcc2 100644 --- a/cli/src/cli-cmd-volume.c +++ b/cli/src/cli-cmd-volume.c @@ -374,12 +374,6 @@ cli_cmd_volume_start_cbk (struct cli_state *state, struct cli_cmd_word *word, goto out; } - if (ret < 0) { - gf_log (THIS->name, GF_LOG_ERROR, - "failed to serialize dict"); - goto out; - } - proc = &cli_rpc_prog->proctable[GLUSTER_CLI_START_VOLUME]; CLI_LOCAL_INIT (local, words, frame, dict); @@ -2414,7 +2408,7 @@ cli_cmd_volume_clearlocks_cbk (struct cli_state *state, out: if (ret) { cli_cmd_sent_status_get (&sent); - if ((sent == 0) && (parse_error = 0)) + if ((sent == 0) && (parse_error == 0)) cli_out ("Volume clear-locks failed"); } -- cgit