From 3c8b3a322d1ecbf99e4718abede32d739bda491c Mon Sep 17 00:00:00 2001 From: Michael Scherer Date: Thu, 23 Feb 2017 22:29:28 +0100 Subject: Do not use va_end before cli_rl_out, since it use ap Trigger a cppcheck error Change-Id: I8919fed47ef562319ac6baff38ed993e7cd54708 BUG: 789278 Signed-off-by: Michael Scherer Reviewed-on: https://review.gluster.org/16741 Smoke: Gluster Build System Reviewed-by: Shyamsundar Ranganathan Tested-by: Michael Scherer NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Jeff Darcy --- cli/src/cli.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'cli') diff --git a/cli/src/cli.c b/cli/src/cli.c index 5f0441fdf98..2a7810d9743 100644 --- a/cli/src/cli.c +++ b/cli/src/cli.c @@ -527,8 +527,9 @@ _cli_err (const char *fmt, ...) #ifdef HAVE_READLINE if (state->rl_enabled && !state->rl_processing) { + ret = cli_rl_err (state, fmt, ap); va_end (ap); - return cli_rl_err (state, fmt, ap); + return ret; } #endif @@ -552,8 +553,9 @@ _cli_out (const char *fmt, ...) va_start (ap, fmt); #ifdef HAVE_READLINE if (state->rl_enabled && !state->rl_processing) { + ret = cli_rl_out (state, fmt, ap); va_end (ap); - return cli_rl_out (state, fmt, ap); + return ret; } #endif -- cgit