From 2e5383266869c13ee27ceaee5b24b686e2415df4 Mon Sep 17 00:00:00 2001 From: Samikshan Bairagya Date: Wed, 28 Dec 2016 20:33:54 +0530 Subject: glusterd: Add info on op-version for clients in vol status output Currently the `gluster volume status clients` command gives us the following information on clients: 1. Brick name 2. Client count for each brick 3. hostname:port for each client 4. Bytes read and written for each client There is no information regarding op-version for each client. This patch adds that to the output. Change-Id: Ib2ece93ab00c234162bb92b7c67a7d86f3350a8d BUG: 1409078 Signed-off-by: Samikshan Bairagya Reviewed-on: http://review.gluster.org/16303 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Atin Mukherjee --- cli/src/cli-xml-output.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'cli/src/cli-xml-output.c') diff --git a/cli/src/cli-xml-output.c b/cli/src/cli-xml-output.c index fe03ea17265..3de7d064bec 100644 --- a/cli/src/cli-xml-output.c +++ b/cli/src/cli-xml-output.c @@ -743,6 +743,7 @@ cli_xml_output_vol_status_clients (xmlTextWriterPtr writer, dict_t *dict, char *hostname = NULL; uint64_t bytes_read = 0; uint64_t bytes_write = 0; + uint32_t opversion = 0; char key[1024] = {0,}; int i = 0; @@ -797,6 +798,17 @@ cli_xml_output_vol_status_clients (xmlTextWriterPtr writer, dict_t *dict, "%"PRIu64, bytes_write); XML_RET_CHECK_AND_GOTO (ret, out); + memset (key, 0, sizeof (key)); + snprintf (key, sizeof (key), "brick%d.client%d.opversion", + brick_index, i); + ret = dict_get_uint32 (dict, key, &opversion); + if (ret) + goto out; + ret = xmlTextWriterWriteFormatElement (writer, + (xmlChar *)"opVersion", + "%"PRIu32, opversion); + XML_RET_CHECK_AND_GOTO (ret, out); + /* */ ret = xmlTextWriterEndElement (writer); XML_RET_CHECK_AND_GOTO (ret, out); -- cgit