From d9a8ccd354df6db94477bf9ecb09735194523665 Mon Sep 17 00:00:00 2001 From: Soumya Koduri Date: Wed, 26 Dec 2018 15:24:49 +0530 Subject: gfapi: nit cleanup related to releasing fs->mutex lock This is follow-up patch to the comment received for - https://review.gluster.org/#/c/glusterfs/+/21882 We need not hold the fs->mutex lock to log error message. Change-Id: I29d2ea2e6cfecc3dd94982bd48f4bc9f11cc3aac fixes: bz#1660577 Signed-off-by: Soumya Koduri --- api/src/glfs-mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'api') diff --git a/api/src/glfs-mgmt.c b/api/src/glfs-mgmt.c index 7ef5ec93af1..e8ad020c752 100644 --- a/api/src/glfs-mgmt.c +++ b/api/src/glfs-mgmt.c @@ -656,9 +656,9 @@ volfile: pthread_mutex_lock(&fs->mutex); if ((size == fs->oldvollen) && (memcmp(fs->oldvolfile, rsp.spec, size) == 0)) { + pthread_mutex_unlock(&fs->mutex); gf_msg(frame->this->name, GF_LOG_INFO, 0, API_MSG_VOLFILE_INFO, "No change in volfile, continuing"); - pthread_mutex_unlock(&fs->mutex); goto out; } pthread_mutex_unlock(&fs->mutex); -- cgit