From 20ef211cfa5b5fcc437484a879fdc5d4c66bbaf5 Mon Sep 17 00:00:00 2001 From: ShyamsundarR Date: Thu, 29 Nov 2018 14:08:06 -0500 Subject: libglusterfs: Move devel headers under glusterfs directory libglusterfs devel package headers are referenced in code using include semantics for a program, this while it works can be better especially when dealing with out of tree xlator builds or in general out of tree devel package usage. Towards this, the following changes are done, - moved all devel headers under a glusterfs directory - Included these headers using system header notation <> in all code outside of libglusterfs - Included these headers using own program notation "" within libglusterfs This change although big, is just moving around the headers and making it correct when including these headers from other sources. This helps us correctly include libglusterfs includes without namespace conflicts. Change-Id: Id2a98854e671a7ee5d73be44da5ba1a74252423b Updates: bz#1193929 Signed-off-by: ShyamsundarR --- api/src/gfapi-messages.h | 2 +- api/src/glfs-fops.c | 4 ++-- api/src/glfs-handleops.c | 4 ++-- api/src/glfs-internal.h | 8 ++++---- api/src/glfs-master.c | 4 ++-- api/src/glfs-mem-types.h | 2 +- api/src/glfs-mgmt.c | 14 +++++++------- api/src/glfs-resolve.c | 16 ++++++++-------- api/src/glfs.c | 18 +++++++++--------- 9 files changed, 36 insertions(+), 36 deletions(-) (limited to 'api') diff --git a/api/src/gfapi-messages.h b/api/src/gfapi-messages.h index 03269a1c9d8..68d12427aea 100644 --- a/api/src/gfapi-messages.h +++ b/api/src/gfapi-messages.h @@ -11,7 +11,7 @@ #ifndef _GFAPI_MESSAGES_H__ #define _GFAPI_MESSAGES_H__ -#include "glfs-message-id.h" +#include /* To add new message IDs, append new identifiers at the end of the list. * diff --git a/api/src/glfs-fops.c b/api/src/glfs-fops.c index 302ccc5db07..2a1cc73ccee 100644 --- a/api/src/glfs-fops.c +++ b/api/src/glfs-fops.c @@ -18,10 +18,10 @@ #include "glfs-internal.h" #include "glfs-mem-types.h" -#include "syncop.h" +#include #include "glfs.h" #include "gfapi-messages.h" -#include "compat-errno.h" +#include #include #include "glusterfs3.h" diff --git a/api/src/glfs-handleops.c b/api/src/glfs-handleops.c index 6a020ca7ab6..3e4e2fb4c52 100644 --- a/api/src/glfs-handleops.c +++ b/api/src/glfs-handleops.c @@ -10,7 +10,7 @@ #include "glfs-internal.h" #include "glfs-mem-types.h" -#include "syncop.h" +#include #include "glfs.h" #include "glfs-handles.h" #include "gfapi-messages.h" @@ -2267,7 +2267,7 @@ out: GFAPI_SYMVER_PUBLIC(glfs_h_poll_upcall370, glfs_h_poll_upcall, 3.7.0); #ifdef HAVE_ACL_LIBACL_H -#include "glusterfs-acl.h" +#include #include int diff --git a/api/src/glfs-internal.h b/api/src/glfs-internal.h index a8d5c59e209..8fdfec8ca02 100644 --- a/api/src/glfs-internal.h +++ b/api/src/glfs-internal.h @@ -11,11 +11,11 @@ #ifndef _GLFS_INTERNAL_H #define _GLFS_INTERNAL_H -#include "xlator.h" -#include "glusterfs.h" -#include "upcall-utils.h" +#include +#include +#include #include "glfs-handles.h" -#include "refcount.h" +#include #define GLFS_SYMLINK_MAX_FOLLOW 2048 diff --git a/api/src/glfs-master.c b/api/src/glfs-master.c index 969095a8224..5c833b6106c 100644 --- a/api/src/glfs-master.c +++ b/api/src/glfs-master.c @@ -15,8 +15,8 @@ #include #include -#include "xlator.h" -#include "glusterfs.h" +#include +#include #include "glfs-internal.h" #include "glfs-mem-types.h" diff --git a/api/src/glfs-mem-types.h b/api/src/glfs-mem-types.h index e1316d128af..bfa325a3ad9 100644 --- a/api/src/glfs-mem-types.h +++ b/api/src/glfs-mem-types.h @@ -11,7 +11,7 @@ #ifndef _GLFS_MEM_TYPES_H #define _GLFS_MEM_TYPES_H -#include "mem-types.h" +#include #define GF_MEM_TYPE_START (gf_common_mt_end + 1) diff --git a/api/src/glfs-mgmt.c b/api/src/glfs-mgmt.c index 87b62173689..bf99005cbc3 100644 --- a/api/src/glfs-mgmt.c +++ b/api/src/glfs-mgmt.c @@ -15,11 +15,11 @@ #include #include -#include "glusterfs.h" +#include #include "glfs.h" -#include "dict.h" -#include "gf-event.h" -#include "defaults.h" +#include +#include +#include #include "rpc-clnt.h" #include "protocol-common.h" @@ -29,13 +29,13 @@ #include "xdr-generic.h" #include "rpc-common-xdr.h" -#include "syncop.h" -#include "xlator.h" +#include +#include #include "glfs-internal.h" #include "glfs-mem-types.h" #include "gfapi-messages.h" -#include "syscall.h" +#include int glfs_volfile_fetch(struct glfs *fs); diff --git a/api/src/glfs-resolve.c b/api/src/glfs-resolve.c index 155d3dc538f..a79f4905749 100644 --- a/api/src/glfs-resolve.c +++ b/api/src/glfs-resolve.c @@ -15,16 +15,16 @@ #include #include -#include "glusterfs.h" -#include "logging.h" -#include "stack.h" -#include "gf-event.h" +#include +#include +#include +#include #include "glfs-mem-types.h" -#include "common-utils.h" -#include "syncop.h" -#include "call-stub.h" +#include +#include +#include #include "gfapi-messages.h" -#include "inode.h" +#include #include "glfs-internal.h" #define graphid_str(subvol) \ diff --git a/api/src/glfs.c b/api/src/glfs.c index 4c951d7b6f1..f9d0937f2b3 100644 --- a/api/src/glfs.c +++ b/api/src/glfs.c @@ -34,17 +34,17 @@ #include #endif -#include "glusterfs.h" -#include "logging.h" -#include "stack.h" -#include "gf-event.h" +#include +#include +#include +#include #include "glfs-mem-types.h" -#include "common-utils.h" -#include "syncop.h" -#include "call-stub.h" -#include "hashfn.h" +#include +#include +#include +#include #include "rpc-clnt.h" -#include "statedump.h" +#include #include "gfapi-messages.h" #include "glfs.h" -- cgit