From e740b700975bdb1014ede99c65731095bdf81a72 Mon Sep 17 00:00:00 2001 From: Kaleb S KEITHLEY Date: Mon, 13 Jun 2016 11:34:51 -0400 Subject: api: use versioned symbols for minor ABI change No need to expand the API/ABI. E.g., see how glfs_lookupat changed between 3.7.0 and 3.7.4 IIRC (I originally argued against versioning the library. I wanted to just add new functions as they were needed, as was initially done for glfs_ipc and glfs_ipc_xd in the master branch for 4.0. But others strongly wanted versioning.) Having made the decision to use versioning, I believe we should continue. At least until we have a public decision that we're no longer going to use versioning. Change-Id: I0c3b2c1cbb297ae2b2864b647c224922987d74ad Signed-off-by: Kaleb S KEITHLEY Reviewed-on: http://review.gluster.org/14717 Reviewed-by: Shyamsundar Ranganathan Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Jeff Darcy --- api/src/glfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'api/src/glfs.c') diff --git a/api/src/glfs.c b/api/src/glfs.c index 1cb6bf7a3cf..8db206de007 100644 --- a/api/src/glfs.c +++ b/api/src/glfs.c @@ -1279,7 +1279,7 @@ invalid_fs: GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_get_volfile, 3.6.0); int -pub_glfs_ipc_xd (struct glfs *fs, int opcode, dict_t *xd_in, dict_t **xd_out) +pub_glfs_ipc (struct glfs *fs, int opcode, void *xd_in, void **xd_out) { xlator_t *subvol = NULL; int ret = -1; @@ -1294,7 +1294,7 @@ pub_glfs_ipc_xd (struct glfs *fs, int opcode, dict_t *xd_in, dict_t **xd_out) goto out; } - ret = syncop_ipc (subvol, opcode, xd_in, xd_out); + ret = syncop_ipc (subvol, opcode, (dict_t *) xd_in, (dict_t **) xd_out); DECODE_SYNCOP_ERR (ret); out: @@ -1305,12 +1305,12 @@ invalid_fs: return ret; } -GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_ipc_xd, 4.0.0); +GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_ipc, 4.0.0); int -pub_glfs_ipc (struct glfs *fs, int opcode) +pub_glfs_ipc37 (struct glfs *fs, int opcode) { - return pub_glfs_ipc_xd (fs, opcode, NULL, NULL); + return pub_glfs_ipc (fs, opcode, NULL, NULL); } -GFAPI_SYMVER_PUBLIC_DEFAULT(glfs_ipc, 3.7.0); +GFAPI_SYMVER_PUBLIC(glfs_ipc37, glfs_ipc, 3.7.0); -- cgit