From eb7ba8984c5e66b57d592f9da606fbdd1133df3b Mon Sep 17 00:00:00 2001 From: Ashish Pandey Date: Mon, 6 Jun 2016 10:17:54 +0530 Subject: cluster/ec: Restrict the launch of replace brick heal Problem: When features.cache-invalidation is ON, a lot of ec_notify function gets called which leads to launch of too many heals. This leads to no heal completion, which causes accumulation of heals. Solution: ec_launch_replace_heal should not be launch for every event. Replace brick will trigger a child up event and then only this heal function should be called. Change-Id: I57b44c6a279d57230daea1d93229be6069245b7d BUG: 1342796 Signed-off-by: Ashish Pandey Reviewed-on: http://review.gluster.org/14649 Reviewed-by: Xavier Hernandez Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System --- xlators/cluster/ec/src/ec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xlators/cluster/ec/src/ec.c b/xlators/cluster/ec/src/ec.c index ab26e882a2e..c803ebfa796 100644 --- a/xlators/cluster/ec/src/ec.c +++ b/xlators/cluster/ec/src/ec.c @@ -519,7 +519,8 @@ unlock: } if (ec->shd.iamshd && - ec->xl_notify_count == ec->nodes) { + ec->xl_notify_count == ec->nodes && + event == GF_EVENT_CHILD_UP) { ec_launch_replace_heal (ec); } out: -- cgit