From ea0634bf88dd63294559c2e4542b73b772b7ec56 Mon Sep 17 00:00:00 2001 From: shishir gowda Date: Fri, 18 Feb 2011 01:27:31 +0000 Subject: Validate peer probe command's hostname/ip address. Note, if an ip octet range exceeds 255, though this fails as a valid ipv4 address, it is still a valid hostname. valid chars are: 'a'-'z', '0' - '9', '-', '.' with a max of 255 chars. Signed-off-by: shishir gowda Signed-off-by: Anand V. Avati BUG: 2194 (gluster peer probe on a ip octet value bigger than 255 has no validation) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2194 --- cli/src/cli-cmd-peer.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/cli/src/cli-cmd-peer.c b/cli/src/cli-cmd-peer.c index ca89592d613..0c4d54dc155 100644 --- a/cli/src/cli-cmd-peer.c +++ b/cli/src/cli-cmd-peer.c @@ -71,6 +71,14 @@ cli_cmd_peer_probe_cbk (struct cli_state *state, struct cli_cmd_word *word, if (ret) goto out; + ret = valid_internet_address ((char *) words[2]); + if (ret == 1) { + ret = 0; + } else { + cli_usage_out (word->pattern); + parse_error = 1; + goto out; + } /* if (words[3]) { ret = dict_set_str (dict, "port", (char *)words[3]); if (ret) -- cgit