From d407c1e6be61211799e3b0bc849134226dc35be7 Mon Sep 17 00:00:00 2001 From: hari Date: Mon, 23 May 2016 12:07:21 +0530 Subject: Glusterd: printing the node details on error message of rebalance back-port of : http://review.gluster.org/#/c/14495 back-port of : http://review.gluster.org/#/c/14540 Problem: on the rebalance start with one of the glusterd being down among the volume, the error message says only about the brick path. Fix: adding the node details >Change-Id: I5827d3a9a15b0461c9ce3a51c0b16246ca58f335 >BUG: 1337899 >Signed-off-by: hari >Change-Id: I3075f3a73e289dfe577742a3d5086531026f567d >BUG: 1339923 >Signed-off-by: hari gowtham Change-Id: Ic3988ff3042808d623642dc5a2ef82ef55ac8424 BUG: 1339928 Signed-off-by: hari gowtham Reviewed-on: http://review.gluster.org/14541 NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Tested-by: hari gowtham Reviewed-by: Zhou Zhengping Reviewed-by: Jeff Darcy Smoke: Gluster Build System --- xlators/mgmt/glusterd/src/glusterd-rebalance.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-rebalance.c b/xlators/mgmt/glusterd/src/glusterd-rebalance.c index 773e59b769a..e0eee02ed52 100644 --- a/xlators/mgmt/glusterd/src/glusterd-rebalance.c +++ b/xlators/mgmt/glusterd/src/glusterd-rebalance.c @@ -717,16 +717,18 @@ glusterd_op_stage_rebalance (dict_t *dict, char **op_errstr) peerinfo = glusterd_peerinfo_find_by_uuid (brickinfo->uuid); if (!peerinfo) { - gf_asprintf (op_errstr, "Host node of " - "brick %s doesn't belong " - "to cluster", + gf_asprintf (op_errstr, "Host node %s " + "of brick %s doesn't " + "belong to cluster", + brickinfo->hostname, brickinfo->path); ret = -1; rcu_read_unlock (); goto out; } else if (!peerinfo->connected) { - gf_asprintf (op_errstr, "Host node of " - "brick %s is down", + gf_asprintf (op_errstr, "Host node %s " + "of brick %s is down", + brickinfo->hostname, brickinfo->path); ret = -1; rcu_read_unlock (); -- cgit