From c1dfc0ca9d06ef9560950c6d374f8e9ed0a53fcd Mon Sep 17 00:00:00 2001 From: Krutika Dhananjay Date: Thu, 2 Jun 2016 19:45:03 +0530 Subject: posix, shard: Use page-aligned buffer for o-direct reads Backport of: http://review.gluster.org/#/c/14639/ and also make shard_readv_do() pass the correct flags when the original fd is opened with O_DIRECT. Change-Id: I253f74459656b047de652b6aace487c0e2ac71f6 BUG: 1342903 Signed-off-by: Krutika Dhananjay Reviewed-on: http://review.gluster.org/14650 Smoke: Gluster Build System CentOS-regression: Gluster Build System NetBSD-regression: NetBSD Build System Reviewed-by: Pranith Kumar Karampuri --- xlators/features/shard/src/shard.c | 3 +++ xlators/storage/posix/src/posix.c | 40 ++++++++++++++++++++++++++++++-------- 2 files changed, 35 insertions(+), 8 deletions(-) diff --git a/xlators/features/shard/src/shard.c b/xlators/features/shard/src/shard.c index 14177a3b77f..df841243926 100644 --- a/xlators/features/shard/src/shard.c +++ b/xlators/features/shard/src/shard.c @@ -3010,6 +3010,9 @@ shard_readv_do (call_frame_t *frame, xlator_t *this) SHARD_SET_ROOT_FS_ID (frame, local); + if (fd->flags & O_DIRECT) + local->flags = O_DIRECT; + while (cur_block <= last_block) { if (wind_failed) { shard_readv_do_cbk (frame, (void *) (long) 0, this, -1, diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c index 582589b5de5..3197ee0ddde 100644 --- a/xlators/storage/posix/src/posix.c +++ b/xlators/storage/posix/src/posix.c @@ -2977,6 +2977,8 @@ posix_readv (call_frame_t *frame, xlator_t *this, int32_t op_ret = -1; int32_t op_errno = 0; int _fd = -1; + char *buf = NULL; + char *alloc_buf = NULL; struct posix_private * priv = NULL; struct iobuf * iobuf = NULL; struct iobref * iobref = NULL; @@ -3015,14 +3017,35 @@ posix_readv (call_frame_t *frame, xlator_t *this, } _fd = pfd->fd; - op_ret = pread (_fd, iobuf->ptr, size, offset); - if (op_ret == -1) { - op_errno = errno; - gf_msg (this->name, GF_LOG_ERROR, errno, P_MSG_READ_FAILED, - "read failed on gfid=%s, fd=%p, offset=%"PRIu64" " - "size=%"GF_PRI_SIZET"", uuid_utoa (fd->inode->gfid), fd, - offset, size); - goto out; + if (pfd->flags & O_DIRECT) { + alloc_buf = _page_aligned_alloc (size, &buf); + if (!alloc_buf) { + op_ret = -1; + op_errno = errno; + goto out; + } + + op_ret = pread (_fd, buf, size, offset); + if (op_ret == -1) { + op_errno = errno; + gf_msg (this->name, GF_LOG_ERROR, errno, + P_MSG_READ_FAILED, "read failed on gfid=%s, " + "fd=%p, offset=%"PRIu64" size=%"GF_PRI_SIZET", " + "buf=%p", uuid_utoa (fd->inode->gfid), fd, + offset, size, buf); + goto out; + } + memcpy(iobuf->ptr, buf, size); + } else { + op_ret = pread (_fd, iobuf->ptr, size, offset); + if (op_ret == -1) { + op_errno = errno; + gf_msg (this->name, GF_LOG_ERROR, errno, P_MSG_READ_FAILED, + "read failed on gfid=%s, fd=%p, offset=%"PRIu64" " + "size=%"GF_PRI_SIZET"", uuid_utoa (fd->inode->gfid), fd, + offset, size); + goto out; + } } LOCK (&priv->lock); @@ -3065,6 +3088,7 @@ out: iobref_unref (iobref); if (iobuf) iobuf_unref (iobuf); + GF_FREE (alloc_buf); return 0; } -- cgit