From c03e07b4147bb2fe902be77f0bbef9c9bae977ab Mon Sep 17 00:00:00 2001 From: ggarg Date: Tue, 17 Jun 2014 16:25:03 +0530 Subject: glusterd: Coverity fix for going out of scope leaks of directory pointer In function volgen_apply_filters() directory stream associated with "filterdir" should be close after opening directory stream corresponding to directory name. closedir() also closes the underlying file descriptor associated with "filterdir". Coverity CID: 1124723 Change-Id: I78ed04047ded98bf95d201afed01c727aa506882 BUG: 789278 Reviewed-on: http://review.gluster.org/8088 Reviewed-by: Atin Mukherjee Tested-by: Gluster Build System Reviewed-by: Kaushal M --- xlators/mgmt/glusterd/src/glusterd-volgen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c index f1e30e1ee82..7981e2977e8 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volgen.c +++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c @@ -1010,6 +1010,8 @@ volgen_apply_filters (char *orig_volfile) free_fp: GF_FREE(filterpath); } + + closedir (filterdir); } static int -- cgit