From bff50319915ff0dfcb9bb8ebc23b40b4341f840f Mon Sep 17 00:00:00 2001 From: Mohit Agrawal Date: Mon, 21 May 2018 09:00:32 +0530 Subject: dht: Avoid dict log flooding for internal MDS xattr Problem: Before populate MDS internal xattr first dht checks if MDS is present in xattr or not.If xattr dictionary is NULL dict_get log the message either dict or key is NULL Solution: Before call dict_get check xattr, if it is NULL then no need to call dict_get. BUG: 1579757 Change-Id: I81604ec5945b85eba14b42f4583d06ec713028f4 Signed-off-by: Mohit Agrawal --- xlators/cluster/dht/src/dht-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c index 3492e7299ed..83942c83daa 100644 --- a/xlators/cluster/dht/src/dht-common.c +++ b/xlators/cluster/dht/src/dht-common.c @@ -855,7 +855,7 @@ dht_common_mark_mdsxattr (call_frame_t *frame, int *errst, int mark_during_fresh and wind a setxattr call on hashed subvol to update internal xattr */ - if (!dict_get (local->xattr, conf->mds_xattr_key)) { + if (!local->xattr || !dict_get (local->xattr, conf->mds_xattr_key)) { /* It means no internal MDS xattr has been set yet */ /* Check the status of all subvol are up while call -- cgit