From 8ee88f074fa1b29c77f6b0f6ef1e027e25bddb04 Mon Sep 17 00:00:00 2001 From: Krutika Dhananjay Date: Mon, 13 May 2013 20:23:23 +0530 Subject: glusterd: Perform NULL check on rsp.op_errstr before using it Change-Id: I2ae30f08965b26a21db541f87de78772cb17135a BUG: 962362 Signed-off-by: Krutika Dhananjay Reviewed-on: http://review.gluster.org/4996 Tested-by: Gluster Build System Reviewed-by: Vijay Bellur --- xlators/mgmt/glusterd/src/glusterd-syncop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-syncop.c b/xlators/mgmt/glusterd/src/glusterd-syncop.c index 68720bdda9c..cebf1977881 100644 --- a/xlators/mgmt/glusterd/src/glusterd-syncop.c +++ b/xlators/mgmt/glusterd/src/glusterd-syncop.c @@ -460,8 +460,7 @@ gd_syncop_brick_op_cbk (struct rpc_req *req, struct iovec *iov, args->errstr = gf_strdup (rsp.op_errstr); out: - if (strcmp (rsp.op_errstr, "") != 0) - free (rsp.op_errstr); + free (rsp.op_errstr); free (rsp.output.output_val); STACK_DESTROY (frame->root); -- cgit