From 8039fcf2571ad7fd9841c8e5605cad9b55d8645c Mon Sep 17 00:00:00 2001 From: Poornima G Date: Fri, 17 Feb 2017 12:17:18 +0530 Subject: readdir-ahead: Remove unnecessary logging dict_get_int can return < 0 when key is not found is a valid case. Hence no need to log. > Reviewed-on: https://review.gluster.org/16654 > NetBSD-regression: NetBSD Build System > CentOS-regression: Gluster Build System > Smoke: Gluster Build System > Reviewed-by: Jeff Darcy Change-Id: If0795b0f178adbb94b10efc563506993f7411962 BUG: 1423429 Signed-off-by: Poornima G Reviewed-on: https://review.gluster.org/16659 NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Smoke: Gluster Build System Reviewed-by: Shyamsundar Ranganathan --- xlators/performance/readdir-ahead/src/readdir-ahead.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xlators/performance/readdir-ahead/src/readdir-ahead.c b/xlators/performance/readdir-ahead/src/readdir-ahead.c index 17569c2a089..c6b167725a5 100644 --- a/xlators/performance/readdir-ahead/src/readdir-ahead.c +++ b/xlators/performance/readdir-ahead/src/readdir-ahead.c @@ -569,12 +569,6 @@ rda_opendir(call_frame_t *frame, xlator_t *this, loc_t *loc, fd_t *fd, local->xattrs = xdata_from_req; ret = dict_get_int32 (xdata, GF_READDIR_SKIP_DIRS, &local->skip_dir); - if (ret < 0) { - gf_msg (this->name, GF_LOG_ERROR, - 0, READDIR_AHEAD_MSG_DICT_OP_FAILED, - "Dict get of key:%s failed with :%d", - GF_READDIR_SKIP_DIRS, ret); - } frame->local = local; } -- cgit