From 5acb74d7daee0fc5c501a82e604ec2abdb3cf88a Mon Sep 17 00:00:00 2001 From: Sunny Kumar Date: Fri, 10 Aug 2018 00:57:09 +0530 Subject: cli : fix few coverity in cli This patch fixes DEADCODE and FORWARD_NULL. CID : 1124495, 1124380, 1124381 Change-Id: I79992e396dbcb1bfe6cd0614d49a8da3f67d648d updates: bz#789278 Signed-off-by: Sunny Kumar --- cli/src/cli-rl.c | 2 ++ cli/src/cli-xml-output.c | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/cli/src/cli-rl.c b/cli/src/cli-rl.c index 1bb9bf07c51..215fbebb998 100644 --- a/cli/src/cli-rl.c +++ b/cli/src/cli-rl.c @@ -295,6 +295,8 @@ cli_rl_autocomplete_prepare (struct cli_state *state, const char *text) if (!word) goto out; + if (!tokens) + return 0; matches = cli_rl_get_matches (state, word, token); state->matches = matches; diff --git a/cli/src/cli-xml-output.c b/cli/src/cli-xml-output.c index 4f912f81043..78aa8439e9d 100644 --- a/cli/src/cli-xml-output.c +++ b/cli/src/cli-xml-output.c @@ -2411,10 +2411,10 @@ cli_xml_output_vol_info_option (xmlTextWriterPtr writer, char *substr, break; ptr1++; ptr2++; - if (!ptr1) - goto out; - if (!ptr2) - goto out; + if (!*ptr1) + break; + if (!*ptr2) + break; } if (*ptr2 == '\0') goto out; -- cgit