From 5602894f0fbb7db476314e28451fbcff848b5b9d Mon Sep 17 00:00:00 2001 From: Krishnan Parthasarathi Date: Thu, 13 Sep 2012 12:33:31 +0530 Subject: cli: Fix double free in cli_add_key_group Change-Id: I3c2f030ac7c53913612a3fbac5e582c47b005621 BUG: 851237 Signed-off-by: Krishnan Parthasarathi Reviewed-on: https://code.engineering.redhat.com/gerrit/1862 Reviewed-by: Vijay Bellur Tested-by: Vijay Bellur --- cli/src/cli-cmd-parser.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cli/src/cli-cmd-parser.c b/cli/src/cli-cmd-parser.c index 8c6e63c6679..8199fbcbcfb 100644 --- a/cli/src/cli-cmd-parser.c +++ b/cli/src/cli-cmd-parser.c @@ -689,12 +689,14 @@ cli_add_key_group (dict_t *dict, char *key, char *value) ret = dict_set_dynstr (dict, iter_key, dkey); if (ret) goto out; + dkey = NULL; snprintf (iter_val, sizeof (iter_val), "value%d", opt_count); dval = gf_strdup (tok_val); ret = dict_set_dynstr (dict, iter_val, dval); if (ret) goto out; + dval = NULL; } -- cgit