From 3687004516e0fc42f1c21f38407d4def7298d6cd Mon Sep 17 00:00:00 2001 From: Atin Mukherjee Date: Tue, 2 Apr 2019 10:45:15 +0530 Subject: logging: Fix GF_LOG_OCCASSIONALLY API GF_LOG_OCCASSIONALLY doesn't log on the first instance rather at every 42nd iterations which isn't effective as in some cases we might not have the code flow hitting the same log for as many as 42 times and we'd end up suppressing the log. Fixes: bz#1695391 Change-Id: Iee293281d25a652b64df111d59b13de4efce06fa Signed-off-by: Atin Mukherjee (cherry picked from commit d0d3e10d44366c68fc153e48b229e72a4aa26e61) --- libglusterfs/src/logging.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libglusterfs/src/logging.h b/libglusterfs/src/logging.h index 859050d568b..64ebdcc54b8 100644 --- a/libglusterfs/src/logging.h +++ b/libglusterfs/src/logging.h @@ -300,7 +300,7 @@ _gf_log_eh(const char *function, const char *fmt, ...) /* Log once in GF_UNIVERSAL_ANSWER times */ #define GF_LOG_OCCASIONALLY(var, args...) \ - if (!(var++ % GF_UNIVERSAL_ANSWER)) { \ + if (var++ == 0 || !((var - 1) % GF_UNIVERSAL_ANSWER)) { \ gf_log(args); \ } -- cgit