From 30ef018c00b0d1be5d590c9518c159a7946d040e Mon Sep 17 00:00:00 2001 From: Ravishankar N Date: Wed, 6 Jan 2016 13:34:01 +0000 Subject: afr : Check if dict is valid in afr_replies_interpret() posix_mkdir does not send response xdata. So even though replies are valid, the response xdata dict is NULL. Check if dict is non-null in afr_replies_interpret before doing dict_get Signed-off-by: Ravishankar N Change-Id: If543d68d8bfd2433519105839d5be106076cc276 BUG: 1294053 Reviewed-on: http://review.gluster.org/13185 Tested-by: Ravishankar N Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Pranith Kumar Karampuri --- xlators/cluster/afr/src/afr-common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xlators/cluster/afr/src/afr-common.c b/xlators/cluster/afr/src/afr-common.c index 9be3670d380..27403eaa58b 100644 --- a/xlators/cluster/afr/src/afr-common.c +++ b/xlators/cluster/afr/src/afr-common.c @@ -701,7 +701,8 @@ afr_replies_interpret (call_frame_t *frame, xlator_t *this, inode_t *inode) continue; } - if (dict_get (replies[i].xdata, GLUSTERFS_BAD_INODE)) { + if (replies[i].xdata && + dict_get (replies[i].xdata, GLUSTERFS_BAD_INODE)) { data_readable[i] = 0; metadata_readable[i] = 0; continue; -- cgit