path: root/rpc/rpc-lib/src/rpc-clnt-ping.h
Commit message (Collapse)AuthorAgeFilesLines
* rpc: Do not reset @ping_started to 0 in ping callbackKrutika Dhananjay2014-07-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is to avoid indefinite recursion of the following kind, that could lead to a stack overflow: rpc_clnt_start_ping() -> rpc_clnt_ping() -> rpc_clnt_submit() -> rpc_clnt_start_ping() -> rpc_clnt_ping() -> rpc_clnt_submit() ... and so on, since it is possible that before rpc_clnt_start_ping() is called a second time by the thread executing this codepath, the response to previous ping request could ALWAYS come by and cause epoll thread to reset conn->ping_started to 0. This patch also fixes the issue of excessive ping traffic, which was due to the client sending one ping rpc for every fop in the worst case. Also removed dead code in glusterd. Change-Id: I7c5e6ae3b1c9d23407c0a12a319bdcb43ba7a359 BUG: 1116243 Signed-off-by: Krutika Dhananjay <> Reviewed-on: Reviewed-by: Pranith Kumar Karampuri <> Tested-by: Gluster Build System <> Reviewed-by: Vijay Bellur <>
* glusterd: Disable ping-timer between glusterd and brick processVijaikumar M2014-05-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | When there are too many IO happening, brick process epoll thread will be busy and fails to respond to the glusterd pick packet within 30sec. Also epoll thread can be blocked by a big-lock. Solution is to disable ping-timer by default and only enable where ever required Later when the epoll thread model changed and made lighter, we need to revert back this change. is one such approach. Change-Id: I7f80ad3eb00f7d9c4d4527305932f7cf4920e73f BUG: 1097224 Signed-off-by: Vijaikumar M <> Reviewed-on: Reviewed-by: Krishnan Parthasarathi <> Tested-by: Gluster Build System <> Reviewed-by: Vijay Bellur <>
* glusterd: Ping timer implmentationKrishnan Parthasarathi2014-04-291-0/+18
This patch refactors the existing client ping timer implementation, and makes use of the common code for implementing both client ping timer and the glusterd ping timer. A new gluster rpc program for ping is introduced. The ping timer is only started for peers that have this new program. The deafult glusterd ping timeout is 30 seconds. It is configurable by setting the option 'ping-timeout' in glusterd.vol . Also, this patch introduces changes in the glusterd-handshake path. The client programs for a peer are now set in the callback of dump_versions, for both the older handshake and the newer op-version handshake. This is the only place in the handshake process where we know what programs a peer supports. Change-Id: I035815ac13449ca47080ecc3253c0a9afbe9016a BUG: 1038261 Signed-off-by: Vijaikumar M <> Signed-off-by: Krishnan Parthasarathi <> Reviewed-on: Tested-by: Gluster Build System <> Reviewed-by: Anand Avati <>