diff options
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c | 288 |
1 files changed, 149 insertions, 139 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c b/xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c index 72baa3424e9..0b56a0eb45a 100644 --- a/xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c +++ b/xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc-helper.c @@ -16,209 +16,219 @@ #include "glusterd-volgen.h" void -glusterd_svc_build_gfproxyd_rundir (glusterd_volinfo_t *volinfo, - char *path, int path_len) +glusterd_svc_build_gfproxyd_rundir(glusterd_volinfo_t *volinfo, char *path, + int path_len) { - char workdir[PATH_MAX] = {0,}; - glusterd_conf_t *priv = THIS->private; + char workdir[PATH_MAX] = { + 0, + }; + glusterd_conf_t *priv = THIS->private; - GLUSTERD_GET_VOLUME_PID_DIR (workdir, volinfo, priv); + GLUSTERD_GET_VOLUME_PID_DIR(workdir, volinfo, priv); - snprintf (path, path_len, "%s", workdir); + snprintf(path, path_len, "%s", workdir); } void -glusterd_svc_build_gfproxyd_socket_filepath (glusterd_volinfo_t *volinfo, - char *path, int path_len) +glusterd_svc_build_gfproxyd_socket_filepath(glusterd_volinfo_t *volinfo, + char *path, int path_len) { - char sockfilepath[PATH_MAX] = {0,}; - char rundir[PATH_MAX] = {0,}; - int32_t len = 0; - - glusterd_svc_build_gfproxyd_rundir (volinfo, rundir, sizeof (rundir)); - len = snprintf (sockfilepath, sizeof (sockfilepath), "%s/run-%s", - rundir, uuid_utoa (MY_UUID)); - if ((len < 0) || (len >= sizeof(sockfilepath))) { - sockfilepath[0] = 0; - } - - glusterd_set_socket_filepath (sockfilepath, path, path_len); + char sockfilepath[PATH_MAX] = { + 0, + }; + char rundir[PATH_MAX] = { + 0, + }; + int32_t len = 0; + + glusterd_svc_build_gfproxyd_rundir(volinfo, rundir, sizeof(rundir)); + len = snprintf(sockfilepath, sizeof(sockfilepath), "%s/run-%s", rundir, + uuid_utoa(MY_UUID)); + if ((len < 0) || (len >= sizeof(sockfilepath))) { + sockfilepath[0] = 0; + } + + glusterd_set_socket_filepath(sockfilepath, path, path_len); } void -glusterd_svc_build_gfproxyd_pidfile (glusterd_volinfo_t *volinfo, - char *path, int path_len) +glusterd_svc_build_gfproxyd_pidfile(glusterd_volinfo_t *volinfo, char *path, + int path_len) { - char rundir[PATH_MAX] = {0,}; + char rundir[PATH_MAX] = { + 0, + }; - glusterd_svc_build_gfproxyd_rundir (volinfo, rundir, sizeof (rundir)); + glusterd_svc_build_gfproxyd_rundir(volinfo, rundir, sizeof(rundir)); - snprintf (path, path_len, "%s/%s.gfproxyd.pid", rundir, volinfo->volname); + snprintf(path, path_len, "%s/%s.gfproxyd.pid", rundir, volinfo->volname); } void -glusterd_svc_build_gfproxyd_volfile_path (glusterd_volinfo_t *volinfo, - char *path, int path_len) +glusterd_svc_build_gfproxyd_volfile_path(glusterd_volinfo_t *volinfo, + char *path, int path_len) { - char workdir[PATH_MAX] = {0,}; - glusterd_conf_t *priv = THIS->private; + char workdir[PATH_MAX] = { + 0, + }; + glusterd_conf_t *priv = THIS->private; - GLUSTERD_GET_VOLUME_DIR (workdir, volinfo, priv); + GLUSTERD_GET_VOLUME_DIR(workdir, volinfo, priv); - snprintf (path, path_len, "%s/%s.gfproxyd.vol", workdir, - volinfo->volname); + snprintf(path, path_len, "%s/%s.gfproxyd.vol", workdir, volinfo->volname); } void -glusterd_svc_build_gfproxyd_logdir (char *logdir, char *volname, size_t len) +glusterd_svc_build_gfproxyd_logdir(char *logdir, char *volname, size_t len) { - snprintf (logdir, len, "%s/gfproxy/%s", DEFAULT_LOG_FILE_DIRECTORY, - volname); + snprintf(logdir, len, "%s/gfproxy/%s", DEFAULT_LOG_FILE_DIRECTORY, volname); } void -glusterd_svc_build_gfproxyd_logfile (char *logfile, char *logdir, size_t len) +glusterd_svc_build_gfproxyd_logfile(char *logfile, char *logdir, size_t len) { - snprintf (logfile, len, "%s/gfproxyd.log", logdir); + snprintf(logfile, len, "%s/gfproxyd.log", logdir); } int -glusterd_is_gfproxyd_enabled (glusterd_volinfo_t *volinfo) +glusterd_is_gfproxyd_enabled(glusterd_volinfo_t *volinfo) { - return glusterd_volinfo_get_boolean (volinfo, VKEY_CONFIG_GFPROXY); + return glusterd_volinfo_get_boolean(volinfo, VKEY_CONFIG_GFPROXY); } static int -glusterd_svc_get_gfproxyd_volfile (glusterd_volinfo_t *volinfo, char *svc_name, - char *orgvol, char **tmpvol, int path_len) +glusterd_svc_get_gfproxyd_volfile(glusterd_volinfo_t *volinfo, char *svc_name, + char *orgvol, char **tmpvol, int path_len) { - int tmp_fd = -1; - int ret = -1; - int need_unlink = 0; - - glusterd_svc_build_gfproxyd_volfile_path (volinfo, orgvol, - path_len); - - ret = gf_asprintf(tmpvol, "/tmp/g%s-XXXXXX", svc_name); - if (ret < 0) { - goto out; - } - - /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */ - tmp_fd = mkstemp (*tmpvol); - if (tmp_fd < 0) { - gf_msg ("glusterd", GF_LOG_WARNING, errno, - GD_MSG_FILE_OP_FAILED, "Unable to create temp file" - " %s:(%s)", *tmpvol, strerror (errno)); - ret = -1; - goto out; - } - - need_unlink = 1; - ret = glusterd_build_gfproxyd_volfile (volinfo, *tmpvol); + int tmp_fd = -1; + int ret = -1; + int need_unlink = 0; + + glusterd_svc_build_gfproxyd_volfile_path(volinfo, orgvol, path_len); + + ret = gf_asprintf(tmpvol, "/tmp/g%s-XXXXXX", svc_name); + if (ret < 0) { + goto out; + } + + /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */ + tmp_fd = mkstemp(*tmpvol); + if (tmp_fd < 0) { + gf_msg("glusterd", GF_LOG_WARNING, errno, GD_MSG_FILE_OP_FAILED, + "Unable to create temp file" + " %s:(%s)", + *tmpvol, strerror(errno)); + ret = -1; + goto out; + } + + need_unlink = 1; + ret = glusterd_build_gfproxyd_volfile(volinfo, *tmpvol); out: - if (need_unlink && ret < 0) - sys_unlink (*tmpvol); + if (need_unlink && ret < 0) + sys_unlink(*tmpvol); - if ((ret < 0) && (*tmpvol != NULL)) { - GF_FREE(*tmpvol); - *tmpvol = NULL; - } + if ((ret < 0) && (*tmpvol != NULL)) { + GF_FREE(*tmpvol); + *tmpvol = NULL; + } - if (tmp_fd >= 0) - sys_close (tmp_fd); + if (tmp_fd >= 0) + sys_close(tmp_fd); - return ret; + return ret; } int -glusterd_svc_check_gfproxyd_volfile_identical (char *svc_name, - glusterd_volinfo_t *volinfo, - gf_boolean_t *identical) +glusterd_svc_check_gfproxyd_volfile_identical(char *svc_name, + glusterd_volinfo_t *volinfo, + gf_boolean_t *identical) { - char orgvol[PATH_MAX] = {0,}; - char *tmpvol = NULL; - int ret = -1; - int need_unlink = 0; + char orgvol[PATH_MAX] = { + 0, + }; + char *tmpvol = NULL; + int ret = -1; + int need_unlink = 0; - GF_VALIDATE_OR_GOTO ("glusterd", identical, out); + GF_VALIDATE_OR_GOTO("glusterd", identical, out); - ret = glusterd_svc_get_gfproxyd_volfile (volinfo, svc_name, orgvol, - &tmpvol, PATH_MAX); - if (ret) - goto out; + ret = glusterd_svc_get_gfproxyd_volfile(volinfo, svc_name, orgvol, &tmpvol, + PATH_MAX); + if (ret) + goto out; - need_unlink = 1; - ret = glusterd_check_files_identical (orgvol, tmpvol, - identical); - if (ret) - goto out; + need_unlink = 1; + ret = glusterd_check_files_identical(orgvol, tmpvol, identical); + if (ret) + goto out; out: - if (need_unlink) - sys_unlink (tmpvol); + if (need_unlink) + sys_unlink(tmpvol); - if (tmpvol != NULL) - GF_FREE (tmpvol); + if (tmpvol != NULL) + GF_FREE(tmpvol); - return ret; + return ret; } int -glusterd_svc_check_gfproxyd_topology_identical (char *svc_name, - glusterd_volinfo_t *volinfo, - gf_boolean_t *identical) +glusterd_svc_check_gfproxyd_topology_identical(char *svc_name, + glusterd_volinfo_t *volinfo, + gf_boolean_t *identical) { - char orgvol[PATH_MAX] = {0,}; - char *tmpvol = NULL; - int ret = -1; - int tmpclean = 0; + char orgvol[PATH_MAX] = { + 0, + }; + char *tmpvol = NULL; + int ret = -1; + int tmpclean = 0; - GF_VALIDATE_OR_GOTO ("glusterd", identical, out); + GF_VALIDATE_OR_GOTO("glusterd", identical, out); - ret = glusterd_svc_get_gfproxyd_volfile (volinfo, svc_name, orgvol, - &tmpvol, PATH_MAX); - if (ret) - goto out; + ret = glusterd_svc_get_gfproxyd_volfile(volinfo, svc_name, orgvol, &tmpvol, + PATH_MAX); + if (ret) + goto out; - tmpclean = 1; /* SET the flag to unlink() tmpfile */ + tmpclean = 1; /* SET the flag to unlink() tmpfile */ - /* Compare the topology of volfiles */ - ret = glusterd_check_topology_identical (orgvol, tmpvol, - identical); + /* Compare the topology of volfiles */ + ret = glusterd_check_topology_identical(orgvol, tmpvol, identical); out: - if (tmpclean) - sys_unlink (tmpvol); + if (tmpclean) + sys_unlink(tmpvol); - if (tmpvol != NULL) - GF_FREE (tmpvol); + if (tmpvol != NULL) + GF_FREE(tmpvol); - return ret; + return ret; } glusterd_volinfo_t * -glusterd_gfproxyd_volinfo_from_svc (glusterd_svc_t *svc) +glusterd_gfproxyd_volinfo_from_svc(glusterd_svc_t *svc) { - glusterd_volinfo_t *volinfo = NULL; - glusterd_gfproxydsvc_t *gfproxyd = NULL; - - /* Get volinfo->gfproxyd from svc object */ - gfproxyd = cds_list_entry (svc, glusterd_gfproxydsvc_t, svc); - if (!gfproxyd) { - gf_msg ("glusterd", GF_LOG_ERROR, 0, - GD_MSG_SNAPD_OBJ_GET_FAIL, "Failed to get gfproxyd " - "object from gfproxyd service"); - goto out; - } - - /* Get volinfo from gfproxyd */ - volinfo = cds_list_entry (gfproxyd, glusterd_volinfo_t, gfproxyd); - if (!volinfo) { - gf_msg ("glusterd", GF_LOG_ERROR, 0, - GD_MSG_VOLINFO_GET_FAIL, "Failed to get volinfo from " - "from gfproxyd"); - goto out; - } + glusterd_volinfo_t *volinfo = NULL; + glusterd_gfproxydsvc_t *gfproxyd = NULL; + + /* Get volinfo->gfproxyd from svc object */ + gfproxyd = cds_list_entry(svc, glusterd_gfproxydsvc_t, svc); + if (!gfproxyd) { + gf_msg("glusterd", GF_LOG_ERROR, 0, GD_MSG_SNAPD_OBJ_GET_FAIL, + "Failed to get gfproxyd " + "object from gfproxyd service"); + goto out; + } + + /* Get volinfo from gfproxyd */ + volinfo = cds_list_entry(gfproxyd, glusterd_volinfo_t, gfproxyd); + if (!volinfo) { + gf_msg("glusterd", GF_LOG_ERROR, 0, GD_MSG_VOLINFO_GET_FAIL, + "Failed to get volinfo from " + "from gfproxyd"); + goto out; + } out: - return volinfo; + return volinfo; } |