diff options
| author | Kotresh HR <khiremat@redhat.com> | 2018-11-02 09:08:42 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2018-11-11 15:43:35 +0000 |
| commit | cefdd02776d204744a13215029f1c3fe024283e4 (patch) | |
| tree | 19408c5354f310a92ff47035948a8dc4ffae87f9 /xlators | |
| parent | 185106a574646bdc2d4ec50756c52db61ad14d98 (diff) | |
ctime: Enable ctime feature by default
This patch does following.
1. Enable ctime feature by default.
2. Earlier, to enable the ctime feature, two options
needed to be enabled
a. gluster vol set <volname> utime on
b. gluster vol set <volname> ctime on
This is inconvenient from the usability point of
view. Hence changed it to following single option
a. gluster vol set <volname> ctime on
fixes: bz#1624724
Change-Id: I04af0e5de1ea6126c58a06ba8a26e22f9f06344e
Signed-off-by: Kotresh HR <khiremat@redhat.com>
Diffstat (limited to 'xlators')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-volgen.c | 12 | ||||
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-volume-set.c | 6 | ||||
| -rw-r--r-- | xlators/storage/posix/src/posix-common.c | 2 |
3 files changed, 7 insertions, 13 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-volgen.c b/xlators/mgmt/glusterd/src/glusterd-volgen.c index b7c658e19fc..4129147daf8 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volgen.c +++ b/xlators/mgmt/glusterd/src/glusterd-volgen.c @@ -4280,16 +4280,10 @@ client_graph_builder(volgen_graph_t *graph, glusterd_volinfo_t *volinfo, } } - ret = dict_get_str_boolean(set_dict, "features.utime", _gf_false); - if (ret == -1) + xl = volgen_graph_add(graph, "features/utime", volname); + if (!xl) { + ret = -1; goto out; - - if (ret) { - xl = volgen_graph_add(graph, "features/utime", volname); - if (!xl) { - ret = -1; - goto out; - } } /* As of now snapshot volume is read-only. Read-only xlator is loaded diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-set.c b/xlators/mgmt/glusterd/src/glusterd-volume-set.c index ac1e011043d..95ed59e7a62 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volume-set.c +++ b/xlators/mgmt/glusterd/src/glusterd-volume-set.c @@ -2351,7 +2351,7 @@ struct volopt_map_entry glusterd_volopt_map[] = { }, { .option = "ctime", - .key = "storage.ctime", + .key = "features.ctime", .voltype = "storage/posix", .op_version = GD_OP_VERSION_4_1_0, }, @@ -2900,10 +2900,10 @@ struct volopt_map_entry glusterd_volopt_map[] = { .value = "off", .op_version = GD_OP_VERSION_4_1_0, .flags = VOLOPT_FLAG_CLIENT_OPT}, - {.key = "features.utime", + {.key = "features.ctime", .voltype = "features/utime", .validate_fn = validate_boolean, - .value = "off", + .value = "on", .option = "!utime", .op_version = GD_OP_VERSION_4_1_0, .description = "enable/disable utime translator on the volume.", diff --git a/xlators/storage/posix/src/posix-common.c b/xlators/storage/posix/src/posix-common.c index 3642d475cb5..8eef765924a 100644 --- a/xlators/storage/posix/src/posix-common.c +++ b/xlators/storage/posix/src/posix-common.c @@ -1327,7 +1327,7 @@ struct volume_options options[] = { "SHA256 checksum. MD5 otherwise."}, {.key = {"ctime"}, .type = GF_OPTION_TYPE_BOOL, - .default_value = "off", + .default_value = "on", .flags = OPT_FLAG_SETTABLE | OPT_FLAG_DOC, .op_version = {GD_OP_VERSION_4_1_0}, .tags = {"ctime"}, |