path: root/xlators
diff options
authorRavishankar N <>2016-06-01 17:57:41 +0530
committerPranith Kumar Karampuri <>2016-06-12 23:42:23 -0700
commit840bc1209c942f110037065ece4a52dce04d36c5 (patch)
treefa699a8afb80c7d6cdf7125d96f888a3898d8aa0 /xlators
parent37ac79fe54e91a8ffe23318855f2cda582a27798 (diff)
afr: Consider ENOSPC and EDQUOT as symmetric errors
Backport of Problem: Since commit 8eaa3506ead4f11b81b146a9e56575c79f3aad7b, in replica 3, if a brick is down and a create fails on the other 2 brick with EDQUOT, we consider it an unsymmetric error and hence do not do post-op. So the dirty xattr remains set on the parent dir, leading to conservative merges during heal when all bricks are up. i.e. a file deleted on the source might re-appear after heal. Fix: Consider ENOSPC and EDQUOT as symmetric errors since there is no possibility of partial inode or entry modification operations possible when quota is enabled. IOW, if quota reports EDQUOT, the no. of bytes written (or not written) will be the same on all bricks of the replica. Likewise, the entry operation (create, mkdir...) will either succeed or not succeed on all bricks. Change-Id: Iacb1108e9ef4a918e36242fb4a957455133744e9 BUG: 1344561 Signed-off-by: Ravishankar N <> Reviewed-on: Smoke: Gluster Build System <> CentOS-regression: Gluster Build System <> NetBSD-regression: NetBSD Build System <> Reviewed-by: Pranith Kumar Karampuri <>
Diffstat (limited to 'xlators')
1 files changed, 1 insertions, 5 deletions
diff --git a/xlators/cluster/afr/src/afr-transaction.c b/xlators/cluster/afr/src/afr-transaction.c
index 994aae18204..ea1f38652d1 100644
--- a/xlators/cluster/afr/src/afr-transaction.c
+++ b/xlators/cluster/afr/src/afr-transaction.c
@@ -640,14 +640,10 @@ afr_handle_symmetric_errors (call_frame_t *frame, xlator_t *this)
i_errno = local->replies[i].op_errno;
- if (i_errno == ENOTCONN || i_errno == EDQUOT ||
- i_errno == ENOSPC) {
+ if (i_errno == ENOTCONN) {
/* ENOTCONN is not a symmetric error. We do not
know if the operation was performed on the
backend or not.
- * Before reaching EDQUOT and ENOSPC, each brick would
- * have written some amount of data, hence this is not
- * symmetric error.
matching_errors = _gf_false;