summaryrefslogtreecommitdiffstats
path: root/xlators
diff options
context:
space:
mode:
authorNigel Babu <nigelb@redhat.com>2017-02-20 08:27:51 +0530
committerShyamsundar Ranganathan <srangana@redhat.com>2017-02-26 11:29:26 -0500
commit688abcc90745515f7e143ef8cf1e938239db597c (patch)
tree829941bd832eaf851af0cc2f2c39806c7886d56e /xlators
parentdc15855cea679affd78d28fd94cbea0c108997f0 (diff)
libglusterfs, gfdb, glusterfs: Add missing breaks
A few switches did not have breaks causing fall throughs. Most of them have been fixed with fall through comments for those that are intentional. Change-Id: I84c85726b542f38504b50fefab5eba5dbcd27a07 BUG: 1424894 Signed-off-by: Nigel Babu <nigelb@redhat.com> Reviewed-on: https://review.gluster.org/16677 NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Jeff Darcy <jdarcy@redhat.com> Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Diffstat (limited to 'xlators')
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-brick-ops.c1
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-snapd-svc.c1
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-syncop.c1
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-tier.c1
-rw-r--r--xlators/protocol/client/src/client-helpers.c1
5 files changed, 5 insertions, 0 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
index 2efa31b814f..7e993e7a231 100644
--- a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
+++ b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
@@ -2924,6 +2924,7 @@ glusterd_op_remove_brick (dict_t *dict, char **op_errstr)
case GF_DEFRAG_STATUS_FAILED:
case GF_DEFRAG_STATUS_COMPLETE:
volinfo->rebal.defrag_status = 0;
+ /* FALLTHROUGH */
default:
break;
}
diff --git a/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c b/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
index acb24fff187..b57542a85a7 100644
--- a/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
+++ b/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
@@ -419,6 +419,7 @@ glusterd_snapdsvc_rpc_notify (glusterd_conn_t *conn, rpc_clnt_event_t event)
case RPC_CLNT_DESTROY:
glusterd_volinfo_unref (volinfo);
+ break;
default:
gf_msg_trace (this->name, 0,
diff --git a/xlators/mgmt/glusterd/src/glusterd-syncop.c b/xlators/mgmt/glusterd/src/glusterd-syncop.c
index 07501f2407d..e5fba968c07 100644
--- a/xlators/mgmt/glusterd/src/glusterd-syncop.c
+++ b/xlators/mgmt/glusterd/src/glusterd-syncop.c
@@ -320,6 +320,7 @@ glusterd_syncop_aggr_rsp_dict (glusterd_op_t op, dict_t *aggr, dict_t *rsp)
case GD_OP_DETACH_TIER_STATUS:
case GD_OP_REMOVE_TIER_BRICK:
ret = glusterd_volume_tier_use_rsp_dict (aggr, rsp);
+ /* FALLTHROUGH */
default:
break;
}
diff --git a/xlators/mgmt/glusterd/src/glusterd-tier.c b/xlators/mgmt/glusterd/src/glusterd-tier.c
index 0afdab56c9c..5f9a08f1909 100644
--- a/xlators/mgmt/glusterd/src/glusterd-tier.c
+++ b/xlators/mgmt/glusterd/src/glusterd-tier.c
@@ -718,6 +718,7 @@ glusterd_op_remove_tier_brick (dict_t *dict, char **op_errstr, dict_t *rsp_dict)
case GF_DEFRAG_STATUS_FAILED:
case GF_DEFRAG_STATUS_COMPLETE:
volinfo->tier.defrag_status = 0;
+ /* FALLTHROUGH */
default:
break;
}
diff --git a/xlators/protocol/client/src/client-helpers.c b/xlators/protocol/client/src/client-helpers.c
index 425c73fb1a5..f9d5c2c8b12 100644
--- a/xlators/protocol/client/src/client-helpers.c
+++ b/xlators/protocol/client/src/client-helpers.c
@@ -1437,6 +1437,7 @@ client_handle_fop_requirements (xlator_t *this, call_frame_t *frame,
&this_req->compound_req_u.compound_lease_req,
op_errno, out, &args->loc, &args->lease,
args->xdata);
+ break;
default:
return ENOTSUP;
}