summaryrefslogtreecommitdiffstats
path: root/xlators
diff options
context:
space:
mode:
authorRavishankar N <ravishankar@redhat.com>2017-12-28 16:02:59 +0530
committerjiffin tony Thottan <jthottan@redhat.com>2018-01-16 03:45:03 +0000
commit3e9a9c029fac359477fb26d9cc7803749ba038b2 (patch)
tree3c8ae4aa410ddb90c5ae16cc8452dd312b5038f1 /xlators
parent5442fb502b360406f8de9787828da2339790da88 (diff)
posix: delete stale gfid handles in nameless lookup
..in order for self-heal of symlinks to work properly (see BZ for details). Change-Id: I9a011d00b07a690446f7fd3589e96f840e8b7501 BUG: 1529488 Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Diffstat (limited to 'xlators')
-rw-r--r--xlators/storage/posix/src/posix-entry-ops.c17
1 files changed, 16 insertions, 1 deletions
diff --git a/xlators/storage/posix/src/posix-entry-ops.c b/xlators/storage/posix/src/posix-entry-ops.c
index 5fb3a4b09c8..4d7ed5be7c8 100644
--- a/xlators/storage/posix/src/posix-entry-ops.c
+++ b/xlators/storage/posix/src/posix-entry-ops.c
@@ -171,7 +171,10 @@ posix_lookup (call_frame_t *frame, xlator_t *this,
dict_t * xattr = NULL;
char * real_path = NULL;
char * par_path = NULL;
+ char *gfid_path = NULL;
+ uuid_t gfid = {0};
struct iatt postparent = {0,};
+ struct stat statbuf = {0};
int32_t gfidless = 0;
char *pgfid_xattr_key = NULL;
int32_t nlink_samepgfid = 0;
@@ -225,7 +228,19 @@ posix_lookup (call_frame_t *frame, xlator_t *this,
"lstat on %s failed",
real_path ? real_path : "null");
}
-
+ if (loc_is_nameless(loc)) {
+ if (!op_errno)
+ op_errno = ESTALE;
+ loc_gfid (loc, gfid);
+ MAKE_HANDLE_ABSPATH (gfid_path, this, gfid);
+ op_ret = sys_lstat(gfid_path, &statbuf);
+ if (op_ret == 0 && statbuf.st_nlink == 1) {
+ gf_msg (this->name, GF_LOG_WARNING, ESTALE,
+ P_MSG_HANDLE_DELETE, "Found stale gfid "
+ "handle %s, removing it.", gfid_path);
+ posix_handle_unset (this, gfid, NULL);
+ }
+ }
entry_ret = -1;
goto parent;
}