path: root/xlators/storage
diff options
authorAnand Avati <>2014-10-28 14:05:06 -0700
committerVijay Bellur <>2014-10-29 01:33:06 -0700
commitef03f98bf9b5f7f317383b84d251299b8939e5cc (patch)
treee9e0d818b77bc253b63050708858db4dd7edd22a /xlators/storage
parent8df26e838c40f15bb2b26131d1533da339f5be3e (diff)
inode: include dentry cycle checks for all existing inodes
inode_link() has the responsibility of maintaining the DAGness of the dentry tree, and prevent cyclic loops from forming. To do this the technique used is to perform cyclic check only while linking inodes which already were linked in the inode table (i.e linking a new_inode() can never form a loop). While this was how it was supposed to be all along, the @old_inode variable was missed out to get updated if the given inode to inode_link itself was already linked (i.e, the code was only handling a complex case when the given new inode had a gfid which already existed) Without this patch, it is possible to call inode_link in a specific way which results in dentry loops. Change-Id: I4c87fa2d63f11e31c73d8b847e56962f6c983880 BUG: 1158226 Signed-off-by: Anand Avati <> Reviewed-on: Reviewed-by: Harshavardhana <> Tested-by: Gluster Build System <> Reviewed-by: Raghavendra G <> Reviewed-by: Pranith Kumar Karampuri <> Tested-by: Pranith Kumar Karampuri <>
Diffstat (limited to 'xlators/storage')
0 files changed, 0 insertions, 0 deletions