summaryrefslogtreecommitdiffstats
path: root/xlators/storage
diff options
context:
space:
mode:
authorKotresh HR <khiremat@redhat.com>2018-06-18 13:40:33 -0400
committerShyamsundar Ranganathan <srangana@redhat.com>2018-07-02 17:14:15 +0000
commit695470765d4d047102fc9d2db7574a6fdb2b3eb3 (patch)
treef2e6a35c036b44d7e83c4431196dd4b85e5aff0d /xlators/storage
parent0894e1d3af83228fb02310e61c1dafea2dc56ef9 (diff)
ctime: Fix self heal of symlink in EC volume
Since IEEE Std 1003.1-2001 does not require any association of file times with symbolic links, there is no requirement that file times be updated by readlink() states [1]. stat on symlink file was generating a readlink fop on one of the subvolumes of ec set which in turn updates atime on that subvolume. This causes mdata xattr to be different across ec set and hence self heal fails. So based on [1], atime is no longer updated by readlink fop. [1] http://pubs.opengroup.org/onlinepubs/009695399/functions/readlink.html Backport of: > Patch: https://review.gluster.org/#/c/20311/ > BUG: 1592509 > Change-Id: I08bd3ca3bdb222bd18160b1aa58fc2f7630c8083 > Signed-off-by: Kotresh HR <khiremat@redhat.com> (cherry picked from commit c097a7894d458e33a41f6db6092677108ef30fec) fixes: bz#1593536 Change-Id: I08bd3ca3bdb222bd18160b1aa58fc2f7630c8083 Signed-off-by: Kotresh HR <khiremat@redhat.com> (cherry picked from commit c097a7894d458e33a41f6db6092677108ef30fec)
Diffstat (limited to 'xlators/storage')
-rw-r--r--xlators/storage/posix/src/posix-inode-fd-ops.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/xlators/storage/posix/src/posix-inode-fd-ops.c b/xlators/storage/posix/src/posix-inode-fd-ops.c
index 6fe25500312..64c7a3240e9 100644
--- a/xlators/storage/posix/src/posix-inode-fd-ops.c
+++ b/xlators/storage/posix/src/posix-inode-fd-ops.c
@@ -1270,8 +1270,6 @@ posix_readlink (call_frame_t *frame, xlator_t *this,
goto out;
}
- posix_set_ctime (frame, this, real_path, -1, loc->inode, &stbuf);
-
dest[op_ret] = 0;
out:
SET_TO_OLD_FS_ID ();