path: root/xlators/storage/posix/src/posix-common.c
diff options
authorPranith Kumar K <>2019-03-11 14:04:39 +0530
committerAmar Tumballi <>2019-03-14 04:47:47 +0000
commitf5987d38f216a3142dfe45f03bf66ff4827d9b55 (patch)
treec661924947831c9b9317758aaa4d0653ca3076e7 /xlators/storage/posix/src/posix-common.c
parent08a9f198d576bbae3596536bbd2c4d34dadd1a93 (diff)
storage/posix: Remove nr_files usage
nr_files is supposed to represent the number of files opened in posix. Present logic doesn't seem to handle anon-fds because of which the counts would always be wrong. I don't remember anyone using this value in debugging any problem probably because we always have 'ls -l /proc/<pid>/fd' which not only prints the fds that are active but also prints their paths. It also handles directories and anon-fds which actually opened the file. So removing this code instead of fixing the buggy logic to have the nr_files. fixes bz#1688106 Change-Id: Ibf8713fdfdc1ef094e08e6818152637206a54040 Signed-off-by: Pranith Kumar K <>
Diffstat (limited to 'xlators/storage/posix/src/posix-common.c')
1 files changed, 0 insertions, 2 deletions
diff --git a/xlators/storage/posix/src/posix-common.c b/xlators/storage/posix/src/posix-common.c
index f0d8e3f..06ff6e6 100644
--- a/xlators/storage/posix/src/posix-common.c
+++ b/xlators/storage/posix/src/posix-common.c
@@ -128,7 +128,6 @@ posix_priv(xlator_t *this)
gf_proc_dump_write("max_read", "%" PRId64, GF_ATOMIC_GET(priv->read_value));
gf_proc_dump_write("max_write", "%" PRId64,
- gf_proc_dump_write("nr_files", "%" PRId64, GF_ATOMIC_GET(priv->nr_files));
return 0;
@@ -776,7 +775,6 @@ posix_init(xlator_t *this)
- GF_ATOMIC_INIT(_private->nr_files, 0);
GF_ATOMIC_INIT(_private->read_value, 0);
GF_ATOMIC_INIT(_private->write_value, 0);