diff options
| author | Prashanth Pai <ppai@redhat.com> | 2018-05-10 18:25:56 +0530 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2018-05-18 04:22:42 +0000 |
| commit | 89e1a4e5720509c096ff6860c1a8c483e0019278 (patch) | |
| tree | 88f1fabf37eff57db85c23822f305f4f16c4e280 /xlators/nfs/server/src/Makefile.am | |
| parent | c2cf3f686f3ea0efd936d2eafc404fc9d2e0acc7 (diff) | |
build: Disallow unresolved symbol references
In the past, it was often[1] forgotten for xlators to be linked against
the symbols they refer to. This often caused glusterd2 to fail while
loading xlator's shared object (.so) file.
This change adds "--no-undefined" as a linker flag which causes the
linker to treat unresolved symbol references as an error and hence fail
linking.
[1]:
https://review.gluster.org/#/c/19912/
https://review.gluster.org/#/c/19664/
https://review.gluster.org/#/c/19056/
https://review.gluster.org/#/c/17659/
https://bugzilla.redhat.com/show_bug.cgi?id=1532238
Bonus:
Added cloudsync and utime xlator's generated source files to .gitignore
Updates: bz#1193929
Change-Id: I9604a4a87b7313a5fa43bda5fdb37dfa7ef8facd
Signed-off-by: Prashanth Pai <ppai@redhat.com>
Diffstat (limited to 'xlators/nfs/server/src/Makefile.am')
| -rw-r--r-- | xlators/nfs/server/src/Makefile.am | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/xlators/nfs/server/src/Makefile.am b/xlators/nfs/server/src/Makefile.am index 5d1136d04ee..dfdcdee8a17 100644 --- a/xlators/nfs/server/src/Makefile.am +++ b/xlators/nfs/server/src/Makefile.am @@ -4,8 +4,9 @@ endif xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/nfs nfsrpclibdir = $(top_srcdir)/rpc/rpc-lib/src -server_la_LDFLAGS = -module -avoid-version -export-symbols \ - $(top_srcdir)/xlators/nfs/server/src/nfsserver.sym +server_la_LDFLAGS = -module -avoid-version \ + -export-symbols $(top_srcdir)/xlators/nfs/server/src/nfsserver.sym \ + $(GF_NO_UNDEFINED) server_la_SOURCES = nfs.c nfs-common.c nfs-fops.c nfs-inodes.c \ nfs-generics.c mount3.c nfs3-fh.c nfs3.c nfs3-helpers.c nlm4.c \ |