summaryrefslogtreecommitdiffstats
path: root/xlators/mgmt/glusterd/src
diff options
context:
space:
mode:
authorKaleb S. KEITHLEY <kkeithle@redhat.com>2020-07-07 09:59:51 -0400
committerAmar Tumballi <amar@kadalu.io>2020-07-09 04:22:05 +0000
commit0f81517e2ba18f0be131fb3afa5aa333890104f2 (patch)
tree5a70e79f89a66293b6628a84d6ef8ca4eff1dfb9 /xlators/mgmt/glusterd/src
parentcdf01cc47eb2efb427b5855732d9607eec2abc8a (diff)
xlator/mgmt/glusterd: lto-type-mismatch
Seen in fedora rawhide/33, and SUSE tumbleweed, in all versions going back at least as far as glusterfs-6. [ 351s] glusterd.c:68:13: warning: type of 'snap_mount_dir' does not match original declaration [-Wlto-type-mismatch] [ 351s] 68 | extern char snap_mount_dir[PATH_MAX]; [ 351s] | ^ [ 351s] glusterd-snapshot.c:65:6: note: array types have different bounds [ 351s] 65 | char snap_mount_dir[VALID_GLUSTERD_PATHMAX]; [ 351s] | ^ [ 351s] glusterd-snapshot.c:65:6: note: 'snap_mount_dir' was previously declared here In this case it's only a warning, but certainly merits fixing. Another case where a decl in a header file instead of open-coding extern decls in multiple .c files would have been preferable. Change-Id: Idc91e536a56a1a7717be83ed27698069e71dff67 Updates: #1002 Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src')
-rw-r--r--xlators/mgmt/glusterd/src/glusterd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd.c b/xlators/mgmt/glusterd/src/glusterd.c
index 94c6154..91c5f9e 100644
--- a/xlators/mgmt/glusterd/src/glusterd.c
+++ b/xlators/mgmt/glusterd/src/glusterd.c
@@ -67,7 +67,7 @@ extern struct rpcsvc_program gd_svc_cli_trusted_progs;
extern struct rpc_clnt_program gd_brick_prog;
extern struct rpcsvc_program glusterd_mgmt_hndsk_prog;
-extern char snap_mount_dir[PATH_MAX];
+extern char snap_mount_dir[VALID_GLUSTERD_PATHMAX];
rpcsvc_cbk_program_t glusterd_cbk_prog = {
.progname = "Gluster Callback",