summaryrefslogtreecommitdiffstats
path: root/xlators/mgmt/glusterd/src/glusterd-svc-helper.c
diff options
context:
space:
mode:
authorBarak Sason Rofman <bsasonro@redhat.com>2020-09-21 11:51:07 +0300
committerMOHIT AGRAWAL <moagrawa@redhat.com>2020-10-07 04:38:50 +0000
commitc271c36ac9dbf47b365cc4e9de0e097fbbcc7945 (patch)
tree2f6a0749e74262f85ac5b17eba4f4bda0fa82e80 /xlators/mgmt/glusterd/src/glusterd-svc-helper.c
parent48a23965493e570827e51ec5018136ebe7897f3c (diff)
DHT - Removing commit hash and 'magical' return value from rebalance
The order of operation in rebalance is as follows: gf_defrag_fix_layout - > gf_defrag_process_dir - > gf_defrag_get_entry gf_defrag_process_dir is passing to gf_defrag_get_entry a pointer to a variable 'gf_defrag_get_entry', however this value is ignored (remains unchanged in the method). Based on the return value from gf_defrag_get_entry, gf_defrag_process_dir may change it's return value to the 'magical' number 2, however since the value of 'should_commit_hash' never changes, this never happnes. All of this is propagated back to gf_defrag_fix_layout and is now removed from there as well. Change-Id: Ibff297650cf84139bd26c830bfa44f81119b60d4 updates: #1002 Signed-off-by: Barak Sason Rofman <bsasonro@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-svc-helper.c')
0 files changed, 0 insertions, 0 deletions