diff options
| author | Atin Mukherjee <amukherj@redhat.com> | 2019-04-25 12:00:52 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2019-05-02 13:36:06 +0530 |
| commit | 91c19c50a3c7b336177dda186500568be43626b8 (patch) | |
| tree | 23e98195583ecd3e989f11792f86f0433bf18e85 /xlators/mgmt/glusterd/src/glusterd-svc-helper.c | |
| parent | 60d6e90bd0565f8d56641ff97dd90348894ac870 (diff) | |
glusterd: Fix coverity defects & put coverity annotations
Along with fixing few defect, put the required annotations for the defects which
are marked ignore/false positive/intentional as per the coverity defect sheet.
This should avoid the per component graph showing many defects as open in the
coverity glusterfs web page.
Updates: bz#789278
Change-Id: I19461dc3603a3bd8f88866a1ab3db43d783af8e4
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-svc-helper.c')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-svc-helper.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-svc-helper.c b/xlators/mgmt/glusterd/src/glusterd-svc-helper.c index f7be3949b37..5b95a026fbe 100644 --- a/xlators/mgmt/glusterd/src/glusterd-svc-helper.c +++ b/xlators/mgmt/glusterd/src/glusterd-svc-helper.c @@ -189,7 +189,7 @@ glusterd_svc_check_volfile_identical(char *svc_name, goto out; } - /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */ + /* coverity[SECURE_TEMP] mkstemp uses 0600 as the mode and is safe */ tmp_fd = mkstemp(tmpvol); if (tmp_fd < 0) { gf_msg(this->name, GF_LOG_WARNING, errno, GD_MSG_FILE_OP_FAILED, @@ -251,7 +251,7 @@ glusterd_svc_check_topology_identical(char *svc_name, goto out; } - /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */ + /* coverity[SECURE_TEMP] mkstemp uses 0600 as the mode and is safe */ tmpfd = mkstemp(tmpvol); if (tmpfd < 0) { gf_msg(this->name, GF_LOG_WARNING, errno, GD_MSG_FILE_OP_FAILED, @@ -308,7 +308,7 @@ glusterd_volume_svc_check_volfile_identical( goto out; } - /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */ + /* coverity[SECURE_TEMP] mkstemp uses 0600 as the mode and is safe */ tmp_fd = mkstemp(tmpvol); if (tmp_fd < 0) { gf_msg(this->name, GF_LOG_WARNING, errno, GD_MSG_FILE_OP_FAILED, @@ -369,7 +369,7 @@ glusterd_volume_svc_check_topology_identical( goto out; } - /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */ + /* coverity[SECURE_TEMP] mkstemp uses 0600 as the mode and is safe */ tmpfd = mkstemp(tmpvol); if (tmpfd < 0) { gf_msg(this->name, GF_LOG_WARNING, errno, GD_MSG_FILE_OP_FAILED, |