summaryrefslogtreecommitdiffstats
path: root/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
diff options
context:
space:
mode:
authorAvra Sengupta <asengupt@redhat.com>2016-03-10 14:32:03 +0530
committerRajesh Joseph <rjoseph@redhat.com>2016-03-11 00:05:28 -0800
commit07a5d9e1e103c8e3ab69283711ee0832d469e145 (patch)
treedc1c30e90248b3d72bbd6bef49139dea504d9717 /xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
parentb9dbfcc8f5a34cea02d97c047ebb24e057b146a3 (diff)
snapshot: Use svc->manager during glusterd restart
Instead of using svc->start, we should use svc->manager as it takes care of initializing svc too, and both starts and stops snapd as needed. Change-Id: I3d3afdf4c4203bee3b790a017b820339fd376af6 BUG: 1316437 Signed-off-by: Avra Sengupta <asengupt@redhat.com> Reviewed-on: http://review.gluster.org/13665 Smoke: Gluster Build System <jenkins@build.gluster.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-snapd-svc.c')
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-snapd-svc.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c b/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
index 82ba7f77551..830dc1a706d 100644
--- a/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
+++ b/xlators/mgmt/glusterd/src/glusterd-snapd-svc.c
@@ -360,15 +360,14 @@ glusterd_snapdsvc_restart ()
cds_list_for_each_entry (volinfo, &conf->volumes, vol_list) {
/* Start per volume snapd svc */
- if (volinfo->status == GLUSTERD_STATUS_STARTED &&
- glusterd_is_snapd_enabled (volinfo)) {
+ if (volinfo->status == GLUSTERD_STATUS_STARTED) {
svc = &(volinfo->snapd.svc);
- ret = svc->start (svc, PROC_START_NO_WAIT);
+ ret = svc->manager (svc, volinfo, PROC_START_NO_WAIT);
if (ret) {
gf_msg (this->name, GF_LOG_ERROR, 0,
GD_MSG_SNAPD_START_FAIL,
- "Couldn't start snapd for "
- "vol: %s", volinfo->volname);
+ "Couldn't resolve snapd for "
+ "vol: %s on restart", volinfo->volname);
goto out;
}
}