path: root/xlators/mgmt/glusterd/src/glusterd-rebalance.c
diff options
authorAtin Mukherjee <>2016-04-11 16:07:40 +0530
committerJeff Darcy <>2016-04-11 11:39:16 -0700
commitd129d4eea33aae5db24dba17adcb04e9d4829817 (patch)
tree24044605fc12b071715ab4f7189672591428942c /xlators/mgmt/glusterd/src/glusterd-rebalance.c
parent65575da24088ba4602b94db649be12376b87484f (diff)
glusterd: populate brickinfo->real_path conditionally
glusterd_brickinfo_new_from_brick () is called from multiple places and one of them is glusterd_brick_rpc_notify where its very well possible that an underlying brick's file system has crashed and a disconnect event has been received. In this case glusterd tries to build the brickinfo from the brickid in the RPC request, however the same fails as glusterd_brickinfo_new_from_brick () fails from realpath. Fix is to skip populating real_path if its a disconnect event. Change-Id: I9d9149c64a9cf2247abb731f219c1b1eef037960 BUG: 1325841 Signed-off-by: Atin Mukherjee <> Reviewed-on: Smoke: Gluster Build System <> CentOS-regression: Gluster Build System <> NetBSD-regression: NetBSD Build System <> Reviewed-by: Jeff Darcy <>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-rebalance.c')
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-rebalance.c b/xlators/mgmt/glusterd/src/glusterd-rebalance.c
index 5bf456b..60d1b20 100644
--- a/xlators/mgmt/glusterd/src/glusterd-rebalance.c
+++ b/xlators/mgmt/glusterd/src/glusterd-rebalance.c
@@ -602,7 +602,8 @@ glusterd_brick_validation (dict_t *dict, char *key, data_t *value,
GF_ASSERT (this);
ret = glusterd_volume_brickinfo_get_by_brick (value->data, volinfo,
- &brickinfo);
+ &brickinfo,
+ _gf_true);
if (ret) {
gf_msg (this->name, GF_LOG_ERROR, EINVAL,