multiple xlators: reduce key length

In many cases, we were freely allocating long keys with no need.
Smaller char arrays are just fine almost anywhere, so just went ahead
and looked where they we can use smaller ones.

In some cases, annotated the functions as static and the prefixes
passed as const as it was easier to read and understand.

Where relevant, converted the dict functions to use known key length.

Change-Id: I882ab33ea20d90b63278336cd1370c09ffdab7f2
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>

1 files changed, 8 insertions, 7 deletions

diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
index 2e57539033e..68166998b49 100644
--- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
+++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
@@ -3182,10 +3182,11 @@ _add_remove_bricks_to_dict(dict_t *dict, glusterd_volinfo_t *volinfo,
     int ret = -1;
     int count = 0;
     int i = 0;
-    char brick_key[1024] = {
+    char brick_key[16] = {
         0,
     };
-    char dict_key[1024] = {
+    char dict_key[64] = {
+        /* dict_key is small as prefix is up to 32 chars */
         0,
     };
     int keylen;
@@ -3250,7 +3251,7 @@ static int
 _add_task_to_dict(dict_t *dict, glusterd_volinfo_t *volinfo, int op, int index)
 {
     int ret = -1;
-    char key[64] = {
+    char key[32] = {
         0,
     };
     int keylen;
@@ -4468,7 +4469,7 @@ glusterd_op_volume_dict_uuid_to_hostname(dict_t *dict, const char *key_fmt,
 {
     int ret = -1;
     int i = 0;
-    char key[1024];
+    char key[128];
     int keylen;
     char *uuid_str = NULL;
     uuid_t uuid = {
@@ -6557,12 +6558,12 @@ fill_shd_status_for_local_bricks(dict_t *dict, glusterd_volinfo_t *volinfo,
                                  dict_t *req_dict)
 {
     glusterd_brickinfo_t *brickinfo = NULL;
-    char *msg = "self-heal-daemon is not running on";
-    char key[1024] = {
+    static char *msg = "self-heal-daemon is not running on";
+    char key[32] = {
         0,
     };
     int keylen;
-    char value[1024] = {
+    char value[128] = {
         0,
     };
     int ret = 0;