diff options
| author | Michael Scherer <misc@redhat.com> | 2017-02-19 16:54:39 +0100 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2017-02-20 22:37:53 -0500 |
| commit | 420c2d03543a35f1f5483f200541577f4a606b22 (patch) | |
| tree | 94b06075985db91e966bc67d52ea0a3514465fdf /xlators/mgmt/glusterd/src/glusterd-handshake.c | |
| parent | 6b42f96d148f0bf36149346196edf5d42bf74941 (diff) | |
Fix erronous comparaison of flags
Using a binary 'or' mean that we always send the
UUID, even when not required.
Found by coverty scan
Change-Id: Ifc4bff6b2f64febd5d2f038538218c2183518fd5
BUG: 1424815
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16675
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Tested-by: Shyamsundar Ranganathan <srangana@redhat.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-handshake.c')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-handshake.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-handshake.c b/xlators/mgmt/glusterd/src/glusterd-handshake.c index 96d39f03007..bcffa5f9969 100644 --- a/xlators/mgmt/glusterd/src/glusterd-handshake.c +++ b/xlators/mgmt/glusterd/src/glusterd-handshake.c @@ -1416,7 +1416,7 @@ __server_get_volume_info (rpcsvc_request_t *req) goto out; } - if (flags | (int32_t)GF_GET_VOLUME_UUID) { + if (flags & (int32_t)GF_GET_VOLUME_UUID) { volume_id_str = gf_strdup (uuid_utoa (volinfo->volume_id)); if (!volume_id_str) { op_errno = ENOMEM; |