diff options
| author | Mohit Agrawal <moagrawal@redhat.com> | 2018-12-07 12:35:20 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2018-12-10 15:04:48 +0000 |
| commit | 2b7b6ff28fa92335613d0b5715acd552cfcfd759 (patch) | |
| tree | f630eda88917d5d071b857c4b0770026593e75df /xlators/mgmt/glusterd/src/glusterd-handler.c | |
| parent | 74c72d0dd9a47b842f4247d939b64089a6fb8e43 (diff) | |
glusterd: Resolve memory leak in some glusterd functions
Problem: Functions allocate memory for req structure but after submit
request they missed to cleanup memory
Solution: After submit request cleanup allocated mmeory
Change-Id: I8f995787ed8986b882f008ccd588670b5d4139f5
updates: bz#1633930
Signed-off-by: Mohit Agrawal <moagrawal@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-handler.c')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-handler.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-handler.c b/xlators/mgmt/glusterd/src/glusterd-handler.c index f9cd600efd4..b07c6017f22 100644 --- a/xlators/mgmt/glusterd/src/glusterd-handler.c +++ b/xlators/mgmt/glusterd/src/glusterd-handler.c @@ -1816,6 +1816,8 @@ out: glusterd_to_cli(req, &rsp, NULL, 0, NULL, (xdrproc_t)xdr_gf_cli_rsp, dict); + GF_FREE(rsp.dict.dict_val); + return 0; } int @@ -1882,6 +1884,8 @@ out: if (dict) dict_unref(dict); + GF_FREE(rsp.dict.dict_val); + glusterd_friend_sm(); glusterd_op_sm(); @@ -4998,6 +5002,7 @@ out: &rsp.dict.dict_len); glusterd_submit_reply(req, &rsp, NULL, 0, NULL, (xdrproc_t)xdr_gf_cli_rsp); + GF_FREE(rsp.dict.dict_val); GF_FREE(key_fixed); return ret; } @@ -5954,6 +5959,7 @@ out: ret = dict_allocate_and_serialize(dict, &rsp.dict.dict_val, &rsp.dict.dict_len); glusterd_to_cli(req, &rsp, NULL, 0, NULL, (xdrproc_t)xdr_gf_cli_rsp, dict); + GF_FREE(rsp.dict.dict_val); return ret; } |