diff options
| author | Atin Mukherjee <amukherj@redhat.com> | 2019-04-26 08:47:12 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2019-04-26 13:15:36 +0000 |
| commit | 13e1fe6dbd39ef88cadce1590b5d4c45b67387cb (patch) | |
| tree | 23e3cf1e4bfe2bacdd2fb15d597eb4c839adda65 /xlators/mgmt/glusterd/src/glusterd-handler.c | |
| parent | 146e4b45d0ce906ae50fd6941a1efafd133897ea (diff) | |
glusterd: coverity fixes
1400775 - USE_AFTER_FREE
1400742 - Missing Unlock
1400736 - CHECKED_RETURN
1398470 - Missing Unlock
Missing unlock is the tricky one, we have had annotation added, but
coverity still continued to complaint. Added pthread_mutex_unlock to
clean up the lock before destroying it to see if it makes coverity
happy.
Updates: bz#789278
Change-Id: I1d892612a17f805144d96c1b15004a85a1639414
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-handler.c')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-handler.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-handler.c b/xlators/mgmt/glusterd/src/glusterd-handler.c index 4b069574bbd..aabfe3f3df5 100644 --- a/xlators/mgmt/glusterd/src/glusterd-handler.c +++ b/xlators/mgmt/glusterd/src/glusterd-handler.c @@ -3288,11 +3288,6 @@ glusterd_friend_remove(uuid_t uuid, char *hostname) ret = glusterd_peerinfo_cleanup(peerinfo); out: gf_msg_debug(THIS->name, 0, "returning %d", ret); - /* We don't need to do a mutex unlock of peerinfo->delete_lock as the same - * will be anyway destroyed within glusterd_peerinfo_cleanup, coverity - * though cries about it - */ - /* coverity[LOCK] */ return ret; } |