path: root/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
diff options
authorRavishankar N <>2017-02-27 13:51:09 +0530
committerAtin Mukherjee <>2017-03-06 08:26:53 -0500
commitb7ba77ab3ffb641d06223f7af5145d3d670b032a (patch)
treec6d44151f93b62a0c14a3970546b8072a54591ca /xlators/mgmt/glusterd/src/glusterd-brick-ops.c
parent804a65f07ea8e2093f781807651d0d07513b2627 (diff)
glusterd: disallow increasing replica count for arbiter volumes
Problem: add-brick command to increase replica count in an arbiter volume succeeds, causing undesirable effects like the 4th brick being loaded with the arbiter xlator, the 3rd one losing the arbiter xlator (when the brick process is restarted), arbitration logic in afr going for a toss etc. Fix: Arbiter configuration should always be a replica 3 volume (of which 3rd brick is arbiter). Hence disallow increasing replica count for arbiter volume configurations. Change-Id: I9fe4edac880d0f711e6d44324ad5562974e53e51 BUG: 1429200 Signed-off-by: Ravishankar N <> Reviewed-on: Smoke: Gluster Build System <> NetBSD-regression: NetBSD Build System <> CentOS-regression: Gluster Build System <> Reviewed-by: Atin Mukherjee <>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-brick-ops.c')
1 files changed, 10 insertions, 0 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
index 7e993e7..edbbdec 100644
--- a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
+++ b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c
@@ -1722,6 +1722,16 @@ glusterd_op_stage_add_brick (dict_t *dict, char **op_errstr, dict_t *rsp_dict)
*op_errstr = gf_strdup (msg);
goto out;
+ /* Do not allow increasing replica count for arbiter volumes. */
+ if (replica_count && volinfo->arbiter_count) {
+ ret = -1;
+ snprintf (msg, sizeof (msg), "Increasing replica count "
+ "for arbiter volumes is not supported.");
+ gf_msg (THIS->name, GF_LOG_ERROR, 0,
+ GD_MSG_BRICK_ADD_FAIL, "%s", msg);
+ *op_errstr = gf_strdup (msg);
+ goto out;
+ }
is_force = dict_get_str_boolean (dict, "force", _gf_false);