summaryrefslogtreecommitdiffstats
path: root/xlators/features
diff options
context:
space:
mode:
authorNandaja Varma <nandaja.varma@gmail.com>2015-02-09 17:16:22 +0530
committerVijay Bellur <vbellur@redhat.com>2015-03-31 01:09:53 -0700
commitd7374684f648c1e45d695454f95a65acfe6d04e8 (patch)
treedddcfa1296372b22ae99944491669dcc25d6d80d /xlators/features
parenta2fa3ba3f6b604b9a5b305092226b12e812fcaf1 (diff)
marker, quota: Fixing the coverity issues
Coverity CIDs: 1124601 1124690 1134008 1134009 Change-Id: I93992b11bb6d8f7edd065f602aec2cd7a8b433d0 BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com> Reviewed-on: http://review.gluster.org/9614 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'xlators/features')
-rw-r--r--xlators/features/marker/src/marker-quota.c3
-rw-r--r--xlators/features/marker/src/marker.c3
-rw-r--r--xlators/features/quota/src/quota.c8
3 files changed, 5 insertions, 9 deletions
diff --git a/xlators/features/marker/src/marker-quota.c b/xlators/features/marker/src/marker-quota.c
index 63aa4efa44d..6034b963dfe 100644
--- a/xlators/features/marker/src/marker-quota.c
+++ b/xlators/features/marker/src/marker-quota.c
@@ -1257,7 +1257,8 @@ mq_set_inode_xattr (xlator_t *this, loc_t *loc)
return 0;
err:
- QUOTA_STACK_DESTROY (frame, this);
+ if (frame)
+ QUOTA_STACK_DESTROY (frame, this);
return 0;
}
diff --git a/xlators/features/marker/src/marker.c b/xlators/features/marker/src/marker.c
index c1db70369a8..dc56714a94c 100644
--- a/xlators/features/marker/src/marker.c
+++ b/xlators/features/marker/src/marker.c
@@ -546,6 +546,9 @@ marker_create_frame (xlator_t *this, marker_local_t *local)
frame = create_frame (this, this->ctx->pool);
+ if (!frame)
+ return -1;
+
frame->local = (void *) local;
marker_start_setxattr (frame, this);
diff --git a/xlators/features/quota/src/quota.c b/xlators/features/quota/src/quota.c
index 5fcc65b7243..2afe58f6210 100644
--- a/xlators/features/quota/src/quota.c
+++ b/xlators/features/quota/src/quota.c
@@ -99,10 +99,6 @@ quota_loc_fill (loc_t *loc, inode_t *inode, inode_t *parent, char *path)
ret = 0;
- if (ret < 0) {
- loc_wipe (loc);
- }
-
return ret;
}
@@ -1275,10 +1271,6 @@ quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
_inode = parent;
just_validated = 0;
- if (_inode == NULL) {
- break;
- }
-
value = 0;
inode_ctx_get (_inode, this, &value);
ctx = (quota_inode_ctx_t *)(unsigned long)value;