quota: fix parents caching during build ancestry

This is a backport of http://review.gluster.org/#/c/11574/

In build ancestry, we get the list of parents for a file,
these parents are cached in inode ctx.
This caching is not happening because posix is not setting
d_stat information in the leaf node entry
This patch fixes the issue

Inode-ctx is not updated with new parent when
rename performed on same directory.
This patch fixes the issue

There is a possibility of caching stale entries,
consider below example:
1) build_ancestry invoked on a file
2) rename is invoked on the same file
3) buils_ancestry prepared entries of old parent
4) rename completed and in cbk old parent is replaced with
       new parent in inode ctx
5) now build_ancestry cbk adds old parent to inode ctx

In this patch we also remove stale entries in writev and fallocate

> Change-Id: Ib1854a41b47b14eb775326588352015c83d034de
> BUG: 1240949
> Signed-off-by: vmallika <vmallika@redhat.com>
> Reviewed-on: http://review.gluster.org/11574
> Tested-by: Gluster Build System <jenkins@build.gluster.com>
> Reviewed-by: Raghavendra G <rgowdapp@redhat.com>

Change-Id: I26a196e7eeed343593bea3a0b7b51d7be12500a3
BUG: 1248325
Signed-off-by: vmallika <vmallika@redhat.com>
Reviewed-on: http://review.gluster.org/11799
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>

2 files changed, 77 insertions, 75 deletions

diff --git a/xlators/features/quota/src/quota.c b/xlators/features/quota/src/quota.c
index 994e5241317..bd022eacdc1 100644
--- a/xlators/features/quota/src/quota.c
+++ b/xlators/features/quota/src/quota.c
@@ -640,7 +640,7 @@ quota_validate_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
         }
         UNLOCK (&ctx->lock);
 
-        quota_check_limit (frame, local->validate_loc.inode, this, NULL, NULL);
+        quota_check_limit (frame, local->validate_loc.inode, this);
         return 0;
 
 unwind:
@@ -1033,13 +1033,13 @@ quota_check_limit_continuation (struct list_head *parents, inode_t *inode,
         if (local->par_frame) {
                 list_for_each_entry (entry, parents, next) {
                         parent = inode_find (inode->table, entry->par);
-                        quota_check_limit (frame, parent, this, NULL, NULL);
+                        quota_check_limit (frame, parent, this);
                         inode_unref (parent);
                 }
         } else {
                 list_for_each_entry (entry, parents, next) {
                         parent = do_quota_check_limit (frame, inode, this,
-                                                       entry);
+                                                       entry, _gf_true);
                         if (parent)
                                 inode_unref (parent);
                         else
@@ -1210,8 +1210,7 @@ out:
 
 
 int32_t
-quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
-                   char *name, uuid_t par)
+quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this)
 {
         int32_t            ret                 = -1, op_errno = EINVAL;
         inode_t           *_inode              = NULL, *parent = NULL;
@@ -1224,7 +1223,6 @@ quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
         gf_boolean_t       hard_limit_exceeded = 0;
         int64_t            delta               = 0;
         uint64_t           value               = 0;
-        uuid_t             trav_uuid           = {0,};
         gf_boolean_t       skip_check          = _gf_false;
 
         GF_VALIDATE_OR_GOTO ("quota", this, err);
@@ -1272,10 +1270,6 @@ quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
         }
         UNLOCK (&local->lock);
 
-        if ( par != NULL ) {
-                gf_uuid_copy (trav_uuid, par);
-        }
-
         do {
                 /* In a rename operation, enforce should be stopped at common
                    ancestor */
@@ -1321,13 +1315,7 @@ quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
                         break;
                 }
 
-                parent = inode_parent (_inode, trav_uuid, name);
-
-                if (name != NULL) {
-                        name = NULL;
-                        gf_uuid_clear (trav_uuid);
-                }
-
+                parent = inode_parent (_inode, 0, NULL);
                 if (parent == NULL) {
                         ret = quota_build_ancestry (_inode,
                                                  quota_check_limit_continuation,
@@ -1365,7 +1353,7 @@ err:
 
 inode_t *
 do_quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
-                      quota_dentry_t *dentry)
+                      quota_dentry_t *dentry, gf_boolean_t force)
 {
         int32_t         ret        = -1;
         inode_t        *parent     = NULL;
@@ -1376,8 +1364,12 @@ do_quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
         local = frame->local;
 
         parent = inode_parent (inode, dentry->par, dentry->name);
-        if (parent == NULL)
-                parent = inode_find (inode->table, dentry->par);
+        if (parent == NULL) {
+                if (force)
+                        parent = inode_find (inode->table, dentry->par);
+                else
+                        goto out;
+        }
         if (parent == NULL)
                 goto out;
 
@@ -1393,7 +1385,7 @@ do_quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
         new_frame->local = new_local;
         new_local->par_frame = frame;
 
-        quota_check_limit (new_frame, parent, this, NULL, NULL);
+        quota_check_limit (new_frame, parent, this);
 
         ret = 0;
 out:
@@ -1851,11 +1843,12 @@ quota_writev (call_frame_t *frame, xlator_t *this, fd_t *fd,
                 /* nameless lookup on this inode, allow quota to reconstruct
                  * ancestry as part of check_limit.
                  */
-                quota_check_limit (frame, fd->inode, this, NULL, NULL);
+                quota_check_limit (frame, fd->inode, this);
         } else {
                 list_for_each_entry_safe (dentry, tmp, &head, next) {
                         par_inode = do_quota_check_limit (frame, fd->inode,
-                                                          this, dentry);
+                                                          this, dentry,
+                                                          _gf_false);
                         if (par_inode == NULL) {
                                 /* remove stale entry from inode ctx */
                                 quota_dentry_del (ctx, dentry->name,
@@ -1874,7 +1867,7 @@ quota_writev (call_frame_t *frame, xlator_t *this, fd_t *fd,
                                 local->link_count++;
                         }
                         UNLOCK (&local->lock);
-                        quota_check_limit (frame, fd->inode, this, NULL, NULL);
+                        quota_check_limit (frame, fd->inode, this);
                 }
 
                 while (fail_count != 0) {
@@ -1983,7 +1976,7 @@ quota_mkdir (call_frame_t *frame, xlator_t *this, loc_t *loc, mode_t mode,
         }
         UNLOCK (&local->lock);
 
-        quota_check_limit (frame, loc->parent, this, NULL, NULL);
+        quota_check_limit (frame, loc->parent, this);
         return 0;
 
 err:
@@ -2132,7 +2125,7 @@ quota_create (call_frame_t *frame, xlator_t *this, loc_t *loc, int32_t flags,
         }
         UNLOCK (&local->lock);
 
-        quota_check_limit (frame, loc->parent, this, NULL, NULL);
+        quota_check_limit (frame, loc->parent, this);
         return 0;
 err:
         QUOTA_STACK_UNWIND (create, frame, -1, op_errno, NULL, NULL, NULL,
@@ -2375,20 +2368,22 @@ quota_link_continue (call_frame_t *frame)
                  * This needs re-vist if marker accounts only once
                  * for the links created across directories
                  */
-                src_parent = inode_parent (local->oldloc.inode, 0, NULL);
-                dst_parent = inode_parent (local->newloc.inode, 0, NULL);
+                if (local->oldloc.parent)
+                        src_parent = inode_ref (local->oldloc.parent);
+                else
+                        src_parent = inode_parent (local->oldloc.inode, 0,
+                                                   NULL);
+                dst_parent = local->newloc.parent;
 
                 /* No need to check quota limit if src and dst parents are same
                  */
                 if (src_parent == dst_parent ||
                     gf_uuid_compare (src_parent->gfid, dst_parent->gfid) == 0) {
                         inode_unref (src_parent);
-                        inode_unref (dst_parent);
-                        goto off;
+                        goto wind;
                 }
 
                 inode_unref (src_parent);
-                inode_unref (dst_parent);
         }
 
         quota_inode_ctx_get (local->oldloc.inode, this, &ctx, 0);
@@ -2407,7 +2402,7 @@ quota_link_continue (call_frame_t *frame)
         }
         UNLOCK (&local->lock);
 
-        quota_check_limit (frame, local->newloc.parent, this, NULL, NULL);
+        quota_check_limit (frame, local->newloc.parent, this);
         return;
 
 err:
@@ -2415,14 +2410,10 @@ err:
                             NULL, NULL, NULL);
         return;
 
-off:
-        frame->local = NULL;
-
-        STACK_WIND_TAIL (frame, FIRST_CHILD(this),
-                         FIRST_CHILD(this)->fops->link, &(local->oldloc),
-                         &(local->newloc), local->xdata);
-
-        quota_local_cleanup (local);
+wind:
+        STACK_WIND (frame, quota_link_cbk, FIRST_CHILD(this),
+                    FIRST_CHILD(this)->fops->link, &(local->oldloc),
+                    &(local->newloc), local->xdata);
         return;
 }
 
@@ -2440,15 +2431,6 @@ quota_link (call_frame_t *frame, xlator_t *this, loc_t *oldloc, loc_t *newloc,
 
         WIND_IF_QUOTAOFF (priv->is_quota_on, off);
 
-        /* No need to check quota limit if src and dst parents are same */
-        if (oldloc->parent && newloc->parent &&
-            !gf_uuid_compare(oldloc->parent->gfid, newloc->parent->gfid)) {
-                gf_msg_debug (this->name, GF_LOG_DEBUG, "link %s -> %s are "
-                              "in the same directory, so skip check limit",
-                              oldloc->path, newloc->path);
-                goto off;
-        }
-
         local = quota_local_new ();
         if (local == NULL) {
                 goto err;
@@ -2480,6 +2462,15 @@ quota_link (call_frame_t *frame, xlator_t *this, loc_t *oldloc, loc_t *newloc,
                 goto err;
         }
 
+        /* No need to check quota limit if src and dst parents are same */
+        if (oldloc->parent && newloc->parent &&
+            !gf_uuid_compare(oldloc->parent->gfid, newloc->parent->gfid)) {
+                gf_msg_debug (this->name, GF_LOG_DEBUG, "link %s -> %s are "
+                              "in the same directory, so skip check limit",
+                              oldloc->path, newloc->path);
+                goto wind;
+        }
+
         stub = fop_link_stub (frame, quota_link_helper, oldloc, newloc, xdata);
         if (stub == NULL) {
                 goto err;
@@ -2496,7 +2487,11 @@ quota_link (call_frame_t *frame, xlator_t *this, loc_t *oldloc, loc_t *newloc,
         check_ancestory (frame, newloc->parent);
 
         /* source parent can be NULL, so do check_ancestory on a file */
-        check_ancestory (frame, oldloc->inode);
+        if (oldloc->parent)
+                check_ancestory (frame, oldloc->parent);
+        else
+                check_ancestory (frame, oldloc->inode);
+
         return 0;
 
 err:
@@ -2509,6 +2504,12 @@ off:
                          FIRST_CHILD(this)->fops->link, oldloc,
                          newloc, xdata);
         return 0;
+
+wind:
+        STACK_WIND (frame, quota_link_cbk, FIRST_CHILD(this),
+                    FIRST_CHILD(this)->fops->link, oldloc,
+                    newloc, xdata);
+        return 0;
 }
 
 
@@ -2534,13 +2535,10 @@ quota_rename_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
 
         GF_VALIDATE_OR_GOTO ("quota", local, out);
 
-        if (QUOTA_REG_OR_LNK_FILE (local->oldloc.inode->ia_type)) {
+        if (QUOTA_REG_OR_LNK_FILE (local->oldloc.inode->ia_type))
                 size = buf->ia_blocks * 512;
-        }
-
-        if (!QUOTA_REG_OR_LNK_FILE (local->oldloc.inode->ia_type)) {
+        else
                 goto out;
-        }
 
         ret = quota_inode_ctx_get (local->oldloc.inode, this, &ctx, 0);
         if ((ret == -1) || (ctx == NULL)) {
@@ -2676,8 +2674,7 @@ quota_rename_get_size_cbk (call_frame_t *frame, void *cookie, xlator_t *this,
                 goto out;
         }
         local->delta = ntoh64 (*size);
-        quota_check_limit (frame, local->newloc.parent, this,
-                           NULL, NULL);
+        quota_check_limit (frame, local->newloc.parent, this);
         return 0;
 
 out:
@@ -2761,7 +2758,7 @@ quota_rename_continue (call_frame_t *frame)
                         return;
         }
 
-        quota_check_limit (frame, local->newloc.parent, this, NULL, NULL);
+        quota_check_limit (frame, local->newloc.parent, this);
         return;
 
 err:
@@ -2785,15 +2782,6 @@ quota_rename (call_frame_t *frame, xlator_t *this, loc_t *oldloc,
 
         WIND_IF_QUOTAOFF (priv->is_quota_on, off);
 
-        /* No need to check quota limit if src and dst parents are same */
-        if (oldloc->parent && newloc->parent &&
-            !gf_uuid_compare(oldloc->parent->gfid, newloc->parent->gfid)) {
-                gf_msg_debug (this->name, 0, "rename %s -> %s are "
-                              "in the same directory, so skip check limit",
-                              oldloc->path, newloc->path);
-                goto off;
-        }
-
         local = quota_local_new ();
         if (local == NULL) {
                 goto err;
@@ -2815,6 +2803,15 @@ quota_rename (call_frame_t *frame, xlator_t *this, loc_t *oldloc,
                 goto err;
         }
 
+        /* No need to check quota limit if src and dst parents are same */
+        if (oldloc->parent && newloc->parent &&
+            !gf_uuid_compare(oldloc->parent->gfid, newloc->parent->gfid)) {
+                gf_msg_debug (this->name, 0, "rename %s -> %s are "
+                              "in the same directory, so skip check limit",
+                              oldloc->path, newloc->path);
+                goto wind;
+        }
+
         stub = fop_rename_stub (frame, quota_rename_helper, oldloc, newloc,
                                 xdata);
         if (stub == NULL) {
@@ -2845,7 +2842,12 @@ off:
         STACK_WIND_TAIL (frame, FIRST_CHILD(this),
                          FIRST_CHILD(this)->fops->rename, oldloc,
                          newloc, xdata);
+        return 0;
 
+wind:
+        STACK_WIND (frame, quota_rename_cbk,
+                    FIRST_CHILD(this), FIRST_CHILD(this)->fops->rename, oldloc,
+                    newloc, xdata);
         return 0;
 }
 
@@ -2975,7 +2977,7 @@ quota_symlink (call_frame_t *frame, xlator_t *this, const char *linkpath,
         }
         UNLOCK (&local->lock);
 
-        quota_check_limit (frame, loc->parent, this, NULL, NULL);
+        quota_check_limit (frame, loc->parent, this);
         return 0;
 
 err:
@@ -3917,7 +3919,7 @@ quota_mknod (call_frame_t *frame, xlator_t *this, loc_t *loc, mode_t mode,
         }
         UNLOCK (&local->lock);
 
-        quota_check_limit (frame, loc->parent, this, NULL, NULL);
+        quota_check_limit (frame, loc->parent, this);
         return 0;
 
 err:
@@ -4857,11 +4859,12 @@ quota_fallocate(call_frame_t *frame, xlator_t *this, fd_t *fd, int32_t mode,
 
         if (parents == 0) {
                 local->link_count = 1;
-                quota_check_limit (frame, fd->inode, this, NULL, NULL);
+                quota_check_limit (frame, fd->inode, this);
         } else {
                 list_for_each_entry_safe (dentry, tmp, &head, next) {
                         par_inode = do_quota_check_limit (frame, fd->inode,
-                                                          this, dentry);
+                                                          this, dentry,
+                                                          _gf_false);
                         if (par_inode == NULL) {
                                 /* remove stale entry from inode_ctx */
                                 quota_dentry_del (ctx, dentry->name,
@@ -4880,7 +4883,7 @@ quota_fallocate(call_frame_t *frame, xlator_t *this, fd_t *fd, int32_t mode,
                                 local->link_count++;
                         }
                         UNLOCK (&local->lock);
-                        quota_check_limit (frame, fd->inode, this, NULL, NULL);
+                        quota_check_limit (frame, fd->inode, this);
                 }
 
                 while (fail_count != 0) {
diff --git a/xlators/features/quota/src/quota.h b/xlators/features/quota/src/quota.h
index 0f8cecd8a59..db27e1e1773 100644
--- a/xlators/features/quota/src/quota.h
+++ b/xlators/features/quota/src/quota.h
@@ -263,12 +263,11 @@ void
 quota_get_limit_dir (call_frame_t *frame, inode_t *cur_inode, xlator_t *this);
 
 int32_t
-quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
-                   char *name, uuid_t par);
+quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this);
 
 inode_t *
 do_quota_check_limit (call_frame_t *frame, inode_t *inode, xlator_t *this,
-                      quota_dentry_t *dentry);
+                      quota_dentry_t *dentry, gf_boolean_t force);
 int
 quota_fill_inodectx (xlator_t *this, inode_t *inode, dict_t *dict,
                      loc_t *loc, struct iatt *buf, int32_t *op_errno);