summaryrefslogtreecommitdiffstats
path: root/xlators/features
diff options
context:
space:
mode:
authoryanping.gao <yanping.gao@xtaotech.com>2016-08-24 06:47:49 +0000
committerPranith Kumar Karampuri <pkarampu@redhat.com>2016-08-24 19:07:03 -0700
commitc85a9ee3198ac63eaa035c8224e514d339bb068b (patch)
treefc30e2f1e0682e958494353da9946d328a7efcbb /xlators/features
parentc70f4b3af619bcdd08d57147a4ed582bdad98084 (diff)
features/locks: fix fdctx leak in locks xlators
Problem: Locks xlators is leaking fdctx in pl_release when inode_ctx_get return non-zero Fix: This patch fixes fdctx leak in pl_release path Change-Id: Icd5c5c681b7d890e7971b3b06d4258a51d45097d Signed-off-by: Yanping.gao <yanping.gao@xtaotech.com> Reviewed-on: http://review.gluster.org/15302 Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com> Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators/features')
-rw-r--r--xlators/features/locks/src/posix.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/features/locks/src/posix.c b/xlators/features/locks/src/posix.c
index 8a142c9991a..149b6eb92a0 100644
--- a/xlators/features/locks/src/posix.c
+++ b/xlators/features/locks/src/posix.c
@@ -2588,7 +2588,7 @@ pl_release (xlator_t *this, fd_t *fd)
ret = inode_ctx_get (fd->inode, this, &tmp_pl_inode);
if (ret != 0)
- goto out;
+ goto clean;
pl_inode = (pl_inode_t *)(long)tmp_pl_inode;
@@ -2600,6 +2600,7 @@ pl_release (xlator_t *this, fd_t *fd)
delete_locks_of_fd (this, pl_inode, fd);
pl_update_refkeeper (this, fd->inode);
+clean:
ret = fd_ctx_del (fd, this, &tmp);
if (ret) {
gf_log (this->name, GF_LOG_DEBUG,