summaryrefslogtreecommitdiffstats
path: root/xlators/features/marker/src/marker-quota.c
diff options
context:
space:
mode:
authorvmallika <vmallika@redhat.com>2015-07-17 12:50:59 +0530
committerRaghavendra G <rgowdapp@redhat.com>2015-07-19 22:16:03 -0700
commit0acd0b45e5ee22eb5bb35c21093136b3b062744f (patch)
treedc2edeaf354b060bc8853c90a970d4fc7e34ea03 /xlators/features/marker/src/marker-quota.c
parent17feb90623750ed003ca7dd0a94a4cf5e20678ae (diff)
quota/marker: contribution with list_del can cause mem corruption
There is a possibility that contribution is removed twice from list during unlink operation (with hard links) or during rename operation Use list_del_init for a thread safe deltion of member from list Change-Id: Iff5e0c03cc8f0ed85da0db1739b84b695abf9ea6 BUG: 1244109 Signed-off-by: vmallika <vmallika@redhat.com> Reviewed-on: http://review.gluster.org/11706 Tested-by: Gluster Build System <jenkins@build.gluster.com> Tested-by: NetBSD Build System <jenkins@build.gluster.org> Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com> Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Diffstat (limited to 'xlators/features/marker/src/marker-quota.c')
-rw-r--r--xlators/features/marker/src/marker-quota.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/features/marker/src/marker-quota.c b/xlators/features/marker/src/marker-quota.c
index a5ef0bb..52b930f 100644
--- a/xlators/features/marker/src/marker-quota.c
+++ b/xlators/features/marker/src/marker-quota.c
@@ -4173,7 +4173,7 @@ mq_forget (xlator_t *this, quota_inode_ctx_t *ctx)
list_for_each_entry_safe (contri, next, &ctx->contribution_head,
contri_list) {
- list_del (&contri->contri_list);
+ list_del_init (&contri->contri_list);
GF_REF_PUT (contri);
}