diff options
author | Yaniv Kaul <ykaul@redhat.com> | 2019-06-09 13:31:31 +0300 |
---|---|---|
committer | Amar Tumballi <amarts@redhat.com> | 2019-06-14 16:50:32 +0000 |
commit | 0a6fe8551ac9807a8b6ad62241ec8048cf9f9025 (patch) | |
tree | 7f6d6b7920ed775c75ca7b4a3dd14aceef5eec38 /xlators/features/locks | |
parent | 65e3624091e895ca32cd91468552589f34d17595 (diff) |
multiple files: another attempt to remove includes
There are many include statements that are not needed.
A previous more ambitious attempt failed because of *BSD plafrom
(see https://review.gluster.org/#/c/glusterfs/+/21929/ )
Now trying a more conservative reduction.
It does not solve all circular deps that we have, but it
does reduce some of them. There is just too much to handle
reasonably (dht-common.h includes dht-lock.h which includes
dht-common.h ...), but it does reduce the overall number of lines
of include we need to look at in the future to understand and fix
the mess later one.
Change-Id: I550cd001bdefb8be0fe67632f783c0ef6bee3f9f
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Diffstat (limited to 'xlators/features/locks')
-rw-r--r-- | xlators/features/locks/src/common.c | 2 | ||||
-rw-r--r-- | xlators/features/locks/src/common.h | 1 | ||||
-rw-r--r-- | xlators/features/locks/src/inodelk.c | 4 | ||||
-rw-r--r-- | xlators/features/locks/src/posix.c | 4 |
4 files changed, 1 insertions, 10 deletions
diff --git a/xlators/features/locks/src/common.c b/xlators/features/locks/src/common.c index ad1ce6c604d..429ce32803e 100644 --- a/xlators/features/locks/src/common.c +++ b/xlators/features/locks/src/common.c @@ -14,9 +14,7 @@ #include <glusterfs/glusterfs.h> #include <glusterfs/compat.h> -#include <glusterfs/xlator.h> #include <glusterfs/logging.h> -#include <glusterfs/common-utils.h> #include <glusterfs/syncop.h> #include "locks.h" diff --git a/xlators/features/locks/src/common.h b/xlators/features/locks/src/common.h index 55603ef9c42..4006062606e 100644 --- a/xlators/features/locks/src/common.h +++ b/xlators/features/locks/src/common.h @@ -10,7 +10,6 @@ #ifndef __COMMON_H__ #define __COMMON_H__ -#include <glusterfs/lkowner.h> /*dump locks format strings */ #define RANGE_FMT "type=%s, whence=%hd, start=%llu, len=%llu" #define ENTRY_FMT "type=%s on basename=%s" diff --git a/xlators/features/locks/src/inodelk.c b/xlators/features/locks/src/inodelk.c index 95afc902ffa..cf556ea12a2 100644 --- a/xlators/features/locks/src/inodelk.c +++ b/xlators/features/locks/src/inodelk.c @@ -9,16 +9,14 @@ */ #include <glusterfs/glusterfs.h> #include <glusterfs/compat.h> -#include <glusterfs/xlator.h> +#include <glusterfs/dict.h> #include <glusterfs/logging.h> -#include <glusterfs/common-utils.h> #include <glusterfs/list.h> #include <glusterfs/upcall-utils.h> #include "locks.h" #include "clear.h" #include "common.h" -#include "pl-messages.h" void __delete_inode_lock(pl_inode_lock_t *lock) diff --git a/xlators/features/locks/src/posix.c b/xlators/features/locks/src/posix.c index d723d798804..c37752da945 100644 --- a/xlators/features/locks/src/posix.c +++ b/xlators/features/locks/src/posix.c @@ -12,11 +12,8 @@ #include <limits.h> #include <pthread.h> -#include <glusterfs/glusterfs.h> #include <glusterfs/compat.h> -#include <glusterfs/xlator.h> #include <glusterfs/logging.h> -#include <glusterfs/common-utils.h> #include "locks.h" #include "common.h" @@ -24,7 +21,6 @@ #include "clear.h" #include <glusterfs/defaults.h> #include <glusterfs/syncop.h> -#include "pl-messages.h" #ifndef LLONG_MAX #define LLONG_MAX LONG_LONG_MAX /* compat with old gcc */ |