summaryrefslogtreecommitdiffstats
path: root/xlators/features/locks/src/posix.c
diff options
context:
space:
mode:
authorZhou Zhengping <johnzzpcrystal@gmail.com>2017-05-09 20:57:34 +0800
committerRaghavendra G <rgowdapp@redhat.com>2017-05-12 04:47:44 +0000
commit333474e0d6efe1a2b3a9ecffc9bdff3e49325910 (patch)
tree176005ae869f739d6e209472d21e87fc7f98d3c0 /xlators/features/locks/src/posix.c
parentccfa06767f1282d9a3783e37555515a63cc62e69 (diff)
libglusterfs: fix race condition in client_ctx_set
follow procedures: 1.thread1 client_ctx_get return NULL 2.thread 2 client_ctx_set ctx1 ok 3.thread1 client_ctx_set ctx2 ok thread1 use ctx1, thread2 use ctx2 and ctx1 will leak Change-Id: I990b02905edd1b3179323ada56888f852d20f538 BUG: 1449232 Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com> Reviewed-on: https://review.gluster.org/17219 NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Raghavendra G <rgowdapp@redhat.com> Smoke: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Diffstat (limited to 'xlators/features/locks/src/posix.c')
-rw-r--r--xlators/features/locks/src/posix.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/xlators/features/locks/src/posix.c b/xlators/features/locks/src/posix.c
index 44ca5004171..1b691c0a878 100644
--- a/xlators/features/locks/src/posix.c
+++ b/xlators/features/locks/src/posix.c
@@ -3480,6 +3480,7 @@ pl_ctx_get (client_t *client, xlator_t *xlator)
{
void *tmp = NULL;
pl_ctx_t *ctx = NULL;
+ pl_ctx_t *setted_ctx = NULL;
client_ctx_get (client, xlator, &tmp);
@@ -3498,10 +3499,11 @@ pl_ctx_get (client_t *client, xlator_t *xlator)
INIT_LIST_HEAD (&ctx->entrylk_lockers);
INIT_LIST_HEAD (&ctx->metalk_list);
- if (client_ctx_set (client, xlator, ctx) != 0) {
+ setted_ctx = client_ctx_set (client, xlator, ctx);
+ if (ctx != setted_ctx) {
pthread_mutex_destroy (&ctx->lock);
GF_FREE (ctx);
- ctx = NULL;
+ ctx = setted_ctx;
}
out:
return ctx;