path: root/xlators/features/changetimerecorder
diff options
authorKaleb S KEITHLEY <>2015-11-18 12:28:42 -0500
committerNiels de Vos <>2016-01-18 01:02:34 -0800
commit50ae3e67e4f294925fc840d3f83b77f7072af54d (patch)
treed682399e0b506b09d3106ea69c0518ea6cd8e0d8 /xlators/features/changetimerecorder
parentf3e03c9d47b7438a6f124e01e2f459c2b72b1c29 (diff)
all: reduce "inline" usage
There are three kinds of inline functions: plain inline, extern inline, and static inline. All three have been removed from .c files, except those in "contrib" which aren't our problem. Inlines in .h files, which are overwhelmingly "static inline" already, have generally been left alone. Over time we should be able to "lower" these into .c files, but that has to be done in a case-by-case fashion requiring more manual effort. This part was easy to do automatically without (as far as I can tell) any ill effect. In the process, several pieces of dead code were flagged by the compiler, and were removed. backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,, BUG: 1245331 Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44 BUG: 1283302 Signed-off-by: Kaleb S KEITHLEY <> Reviewed-on: Smoke: Gluster Build System <> NetBSD-regression: NetBSD Build System <> CentOS-regression: Gluster Build System <> Reviewed-by: Niels de Vos <>
Diffstat (limited to 'xlators/features/changetimerecorder')
2 files changed, 5 insertions, 5 deletions
diff --git a/xlators/features/changetimerecorder/src/changetimerecorder.c b/xlators/features/changetimerecorder/src/changetimerecorder.c
index de42c3f..47de911 100644
--- a/xlators/features/changetimerecorder/src/changetimerecorder.c
+++ b/xlators/features/changetimerecorder/src/changetimerecorder.c
@@ -79,7 +79,7 @@ What is pending:
/* This function doesnot write anything to the db,
* just created the local variable
* for the frame and sets values for the ctr_db_record */
-static inline int
+static int
ctr_lookup_wind(call_frame_t *frame,
xlator_t *this,
gf_ctr_inode_context_t *ctr_inode_cx)
@@ -151,7 +151,7 @@ out:
/* This function inserts the ctr_db_record populated by ctr_lookup_wind
* in to the db. It also destroys the frame->local created by ctr_lookup_wind */
-static inline int
+static int
ctr_lookup_unwind (call_frame_t *frame,
xlator_t *this)
diff --git a/xlators/features/changetimerecorder/src/ctr-xlator-ctx.c b/xlators/features/changetimerecorder/src/ctr-xlator-ctx.c
index b5a54c0..c5900ea 100644
--- a/xlators/features/changetimerecorder/src/ctr-xlator-ctx.c
+++ b/xlators/features/changetimerecorder/src/ctr-xlator-ctx.c
@@ -17,7 +17,7 @@
(ctr_hard_link-> == ctr_hard_link->list.prev)
-static inline void
+static void
fini_ctr_hard_link (ctr_hard_link_t **ctr_hard_link) {
GF_ASSERT (ctr_hard_link);
@@ -246,7 +246,7 @@ out:
/* Delete all hardlinks */
-static inline int
+static int
ctr_delete_all_hard_link (xlator_t *this,
ctr_xlator_ctx_t *ctr_xlator_ctx)
@@ -277,7 +277,7 @@ ctr_delete_all_hard_link (xlator_t *this,
/* Please lock the inode before using this function */
-static inline ctr_xlator_ctx_t *
+static ctr_xlator_ctx_t *
__get_ctr_xlator_ctx (xlator_t *this,
inode_t *inode)